check for HTML accept type for SPA routes

ProjectEvergreen · Jun 22, 2024 · d4f5201 · d4f5201
1 parent b25831b
commit d4f5201
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/cli/src/plugins/resource/plugin-standard-html.js b/packages/cli/src/plugins/resource/plugin-standard-html.js
@@ -26,12 +26,12 @@ class StandardHtmlResource extends ResourceInterface {
     this.contentType = 'text/html';
   }
 
-  async shouldServe(url) {
+  async shouldServe(url, request) {
     const { protocol, pathname } = url;
     const hasMatchingPageRoute = this.compilation.graph.find(node => node.route === pathname);
     const isSPA = this.compilation.graph.find(node => node.isSPA) && pathname.indexOf('.') < 0;
 
-    return protocol.startsWith('http') && (hasMatchingPageRoute || isSPA);
+    return protocol.startsWith('http') && (hasMatchingPageRoute || (isSPA && request.headers.get('Accept').indexOf('text/html') >= 0));
   }
 
   async serve(url, request) {

diff --git a/packages/cli/test/cases/develop.spa/develop.spa.spec.js b/packages/cli/test/cases/develop.spa/develop.spa.spec.js
@@ -77,7 +77,7 @@ describe('Develop Greenwood With: ', function() {
       let body;
 
       before(async function() {
-        response = await fetch(`${hostname}:${port}/`);
+        response = await fetch(`${hostname}:${port}/`, { headers: { 'Accept': 'text/html' } });
         body = await response.clone().text();
       });
 
@@ -103,7 +103,7 @@ describe('Develop Greenwood With: ', function() {
       let body;
 
       before(async function() {
-        response = await fetch(`http://127.0.0.1:${port}/artists/`);
+        response = await fetch(`http://127.0.0.1:${port}/artists/`, { headers: { 'Accept': 'text/html' } });
         body = await response.clone().text();
       });
 
@@ -129,7 +129,7 @@ describe('Develop Greenwood With: ', function() {
       let body;
 
       before(async function() {
-        response = await fetch(`http://127.0.0.1:${port}/artists/1`);
+        response = await fetch(`http://127.0.0.1:${port}/artists/1`, { headers: { 'Accept': 'text/html' } });
         body = await response.clone().text();
       });