Fixed getting entry bearing for maneuver. #4353
Conversation
| @@ -123,7 +123,7 @@ bool isStaggeredIntersection(const RouteStepIterator step_prior_to_intersection, | |||
|
|
|||
| const auto angle = [](const RouteStep &step) { | |||
| const auto &intersection = step.intersections.front(); | |||
| const auto entry_bearing = intersection.bearings[intersection.in]; | |||
| const auto entry_bearing = util::bearing::reverse(intersection.bearings[intersection.in]); | |||
There was a problem hiding this comment.
Can you elaborate a bit on how you verified that this is necessary?
Off the top of my head and without having checked again:
The bearings for an intersection could look like [0,90,180,270] while in = 0, out = 2.
This would represent a straight traversal on the north-south axis (note that the bearings are stored from the center of the intersection, so in is already reversed).
The angle between in and out in this representation should be 180 degree, which would be the case without reversing the bearing.
(see is_right: > 45 < 135).
With reversing, both bearings would be identical and there would be a turn angle of zero.
I might be totally off here, though.
There was a problem hiding this comment.
'in' bearing in the intersection struct is stored opposite to the driving direction. You can ensure about it in the assembleSteps function here
'in' bearing from intersection also reversed here and here while passing to bearing::angleBetween.
But now I'm confused with the bearings::angleBetween function:
bearings::angleBetween(0, 0) == bearings::angleBetween(180, 180) == 180;
bearings::angleBetween(0, 180) == bearings::angleBetween(180, 0) == 0;
Seems like it's made specially for the opposite driving direction 'in' bearing. In that case, the logic in collapse_turns.cpp or post_processing.cpp should also be reviewed.
There was a problem hiding this comment.
From the values @vng posted, the change should be fine. It is void, since is_right and is_left are used in combination (right + left), but it might prevent future bugs.
To get entry bearing for maneuver, we need to reverse 'in' bearing for intersection, how it's made in other functions.