initial unit tests for dice loss #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
force-pushed
the
10-dice-loss-function
branch
from
10dc087 to
9479679
Compare
ericspod
approved these changes
Jan 16, 2020
- triggering unit tests via github workflow - renamed testconvolutions.py to test_convolutions.py - test unet test cases as variables for readability
Nic-Ma
pushed a commit
that referenced
this pull request
Jan 21, 2020
* Adding script to run unit tests and example test cases (#29) Adding script to run unit tests and example test cases * initial unit tests for dice loss (#27) * initial unit tests for 2d/3d unet * unit tests update - triggering unit tests via github workflow - renamed testconvolutions.py to test_convolutions.py - test unet test cases as variables for readability * initial unit tests for 2d/3d unet (#26) * initial unit tests for 2d/3d unet * unit tests update - triggering unit tests via github workflow - renamed testconvolutions.py to test_convolutions.py - test unet test cases as variables for readability * 14 code examples of monai input data pipeline (#24) * fixes cardiac example * update example cardiac segmentation * Create .gitlab-ci.yml (#30) an initial step towards #19 * tests intensity normalizer - revised to support both `[key]` and `key` as an input for apply_keys - added `NumpyImageTestCase2D` and `TorchImageTestCase2D` * style updates and new test cases: - adding copyright notice - validate user input before setting class member - one line space after copyright - testing multiple keys input data Co-authored-by: Eric Kerfoot <[email protected]> Co-authored-by: Isaac Yang <[email protected]>
ericspod
added a commit
that referenced
this pull request
Jan 22, 2020
* [DLMED] implement intensity normalization transform design according to our latest discussion: 1. input data is dict format with keys for fields. 2. only based on PyTorch and data shape is channel_last. * 9 part a adding test intensity normalisation transform (#33) * Adding script to run unit tests and example test cases (#29) Adding script to run unit tests and example test cases * initial unit tests for dice loss (#27) * initial unit tests for 2d/3d unet * unit tests update - triggering unit tests via github workflow - renamed testconvolutions.py to test_convolutions.py - test unet test cases as variables for readability * initial unit tests for 2d/3d unet (#26) * initial unit tests for 2d/3d unet * unit tests update - triggering unit tests via github workflow - renamed testconvolutions.py to test_convolutions.py - test unet test cases as variables for readability * 14 code examples of monai input data pipeline (#24) * fixes cardiac example * update example cardiac segmentation * Create .gitlab-ci.yml (#30) an initial step towards #19 * tests intensity normalizer - revised to support both `[key]` and `key` as an input for apply_keys - added `NumpyImageTestCase2D` and `TorchImageTestCase2D` * style updates and new test cases: - adding copyright notice - validate user input before setting class member - one line space after copyright - testing multiple keys input data Co-authored-by: Eric Kerfoot <[email protected]> Co-authored-by: Isaac Yang <[email protected]> * [DLMED] simplify intensity normalization transform for MVP Co-authored-by: Wenqi Li <[email protected]> Co-authored-by: Eric Kerfoot <[email protected]> Co-authored-by: Isaac Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dice loss is already implemented in the repo and should be enough for the MVP.
This PR provides a gentle unit test for the module.
closes #10.
next steps: