Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial unit tests for 2d/3d unet #26

Merged
merged 5 commits into from
Jan 17, 2020
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 14, 2020

2D/3D unet is already implemented in the repo and should be enough for the MVP. This PR provides a gentle unit test for the module.
closes #13.

next steps:

  • the module lacks proper documentation
  • the unit tests are incomplete
  • the network should support multichannel inputs (which is not the case currently)

@wyli wyli requested review from atbenmurray and ericspod January 14, 2020 14:27
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here perhaps move the arguments for parameterized into a separate variable for readability, otherwise is good to go.

wyli added 2 commits January 17, 2020 12:13
 - triggering unit tests via github workflow
 - renamed testconvolutions.py to test_convolutions.py
 - test unet test cases as variables for readability
@wyli wyli requested a review from ericspod January 17, 2020 12:51
@wyli wyli merged commit 4bd517a into master Jan 17, 2020
Nic-Ma pushed a commit that referenced this pull request Jan 21, 2020
* Adding script to run unit tests and example test cases (#29)

Adding script to run unit tests and example test cases

* initial unit tests for dice loss (#27)

* initial unit tests for 2d/3d unet
* unit tests update
 - triggering unit tests via github workflow
 - renamed testconvolutions.py to test_convolutions.py
 - test unet test cases as variables for readability

* initial unit tests for 2d/3d unet (#26)

* initial unit tests for 2d/3d unet
* unit tests update
 - triggering unit tests via github workflow
 - renamed testconvolutions.py to test_convolutions.py
 - test unet test cases as variables for readability

* 14 code examples of monai input data pipeline (#24)

* fixes cardiac example

* update example cardiac segmentation

* Create .gitlab-ci.yml (#30)

an initial step towards #19

* tests intensity normalizer

- revised to support both `[key]` and `key` as an input for apply_keys
- added `NumpyImageTestCase2D` and `TorchImageTestCase2D`

* style updates and new test cases:

- adding copyright notice
- validate user input before setting class member
- one line space after copyright
- testing multiple keys input data

Co-authored-by: Eric Kerfoot <[email protected]>
Co-authored-by: Isaac Yang <[email protected]>
ericspod added a commit that referenced this pull request Jan 22, 2020
* [DLMED] implement intensity normalization transform

design according to our latest discussion:
1. input data is dict format with keys for fields.
2. only based on PyTorch and data shape is channel_last.

* 9 part a adding test intensity normalisation transform (#33)

* Adding script to run unit tests and example test cases (#29)

Adding script to run unit tests and example test cases

* initial unit tests for dice loss (#27)

* initial unit tests for 2d/3d unet
* unit tests update
 - triggering unit tests via github workflow
 - renamed testconvolutions.py to test_convolutions.py
 - test unet test cases as variables for readability

* initial unit tests for 2d/3d unet (#26)

* initial unit tests for 2d/3d unet
* unit tests update
 - triggering unit tests via github workflow
 - renamed testconvolutions.py to test_convolutions.py
 - test unet test cases as variables for readability

* 14 code examples of monai input data pipeline (#24)

* fixes cardiac example

* update example cardiac segmentation

* Create .gitlab-ci.yml (#30)

an initial step towards #19

* tests intensity normalizer

- revised to support both `[key]` and `key` as an input for apply_keys
- added `NumpyImageTestCase2D` and `TorchImageTestCase2D`

* style updates and new test cases:

- adding copyright notice
- validate user input before setting class member
- one line space after copyright
- testing multiple keys input data

Co-authored-by: Eric Kerfoot <[email protected]>
Co-authored-by: Isaac Yang <[email protected]>

* [DLMED] simplify intensity normalization transform for MVP

Co-authored-by: Wenqi Li <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]>
Co-authored-by: Isaac Yang <[email protected]>
@wyli wyli deleted the 13-2d-3d-unet-architecture branch April 6, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D/3D UNet architecture
2 participants