Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuepress1.0 upgrade #1408

Merged
merged 5 commits into from
Aug 27, 2019
Merged

Conversation

znicholasbrown
Copy link
Contributor

@znicholasbrown znicholasbrown commented Aug 27, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Resolves #770 by upgrading Vuepress to v1.0.3
Makes the appropriate modifications to migrate to the most recent version, including changes to imports and style overrides.

Why is this PR important?

We were using an unsupported version of Vuepress that didn't allow us flexibility to override components and address issues like #1119

Notes

There are a few places where the style wasn't exactly matched to the live version.
This was for a few reasons:

  • sometimes it wasn't worth the effort (and would potentially be breaking)
  • it looked better/was clearer in the updated version

Some notable differences are in the sidenav hierarchy styling (the active link is now highlighted in blue when not focused), and the GitHub outbound link is now correctly vertically centered.

Nicholas added 3 commits August 26, 2019 19:18
…st page of the docs. Adds some override styling for the default theme to bring the upgrade more in line with the current live version.
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1408 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@znicholasbrown znicholasbrown mentioned this pull request Aug 27, 2019
3 tasks
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you so much! My immediate thought when I saw this was "ooo now we can have a copy icon for code blocks!" and lo and behold, another PR appeared...

@cicdw cicdw merged commit b4bba28 into PrefectHQ:master Aug 27, 2019
abrookins pushed a commit that referenced this pull request Mar 15, 2022
BugFix: Task run links not showing up in orion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade VuePress to 1.0
2 participants