-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade VuePress to 1.0 #770
Comments
Quick notes from trying this and using the suggested migrations:
|
@jlowin did you already upgrade to vuepress 1.0 and run into this? just need to know the steps i need to take here :) |
Yes, I actually have a branch that I just pushed called |
The only remaining blocker is the syntax highlighting, I've solved the rest (though a couple class names changed so we'll need to review for some that aren't picking up our styles) |
Just walked through with @dylanbhughes and our conclusion is that VuePress is not ready at this time. The dev server and actual build give very different output right now. Ironically, the built output is close to "correct" but the dev server is not. We will stick to pre-1.0 until this is resolved, as the UX of working with a dev server that doesn't reflect reality is terrible. In particular, the syntax highlighting is illegible. |
looks like they recently made a fix with the latest vuepress release 1.0.0-alpha.47 — see changelog for more info. went ahead and upgraded along with few changes to get syntax highlighting to work on dev so it should match production build now! pushed changes to your a lot of the styling mishaps i noticed is due to their structural changes in 1.x as well. they changed a lot of their structure to use semantic HTML as well as updated some class names so i'll make another branch for styling-specific changes! |
Thanks @itsngansense! Confirm we're now unblocked by that issue. Unfortunately it looks like |
In addition, the top-level sidebar name for all API references is wrong, it appears not to look through the HTML at the top of the README.md |
No description provided.
The text was updated successfully, but these errors were encountered: