-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin pytest for ddtrace #11849
Pin pytest for ddtrace #11849
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The warning handling change a bit in pytest 8, we should probably just revert my bump PR: #11821 |
This reverts commit c1a3416.
I just pushed a commit to revert the pytest=8 PR, I'll keep an eye on test results now. |
@@ -72,6 +72,7 @@ def cleanup_all_new_docker_objects(docker: DockerClient, worker_id: str): | |||
logger.warning("Failed to clean up Docker objects") | |||
|
|||
|
|||
@pytest.mark.timeout(120) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already addressed this one by moving it up to a pytestmark
, let's just drop this line here:
@pytest.mark.timeout(120) |
Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.