Pin pytest for ddtrace #11849
Merged
Pin pytest for ddtrace #11849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisguidry
approved these changes
Feb 5, 2024
zzstoatzz
approved these changes
Feb 5, 2024
|
The warning handling change a bit in pytest 8, we should probably just revert my bump PR: #11821 |
This reverts commit c1a3416.
|
I just pushed a commit to revert the pytest=8 PR, I'll keep an eye on test results now. |
chrisguidry
reviewed
Feb 5, 2024
| @@ -72,6 +72,7 @@ def cleanup_all_new_docker_objects(docker: DockerClient, worker_id: str): | |||
| logger.warning("Failed to clean up Docker objects") | |||
|
|
|||
|
|
|||
| @pytest.mark.timeout(120) | |||
There was a problem hiding this comment.
I've already addressed this one by moving it up to a pytestmark, let's just drop this line here:
Suggested change
| @pytest.mark.timeout(120) |
serinamarie
added
the
development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
netlify.tomlfor files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.ymlnavigation.