Bump pytest to 8.0 #11821
Merged
Bump pytest to 8.0 #11821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bunchesofdonald
commented
Feb 2, 2024
| @@ -72,7 +72,6 @@ def cleanup_all_new_docker_objects(docker: DockerClient, worker_id: str): | |||
| logger.warning("Failed to clean up Docker objects") | |||
|
|
|||
|
|
|||
| @pytest.mark.timeout(120) | |||
There was a problem hiding this comment.
This was the only specific pytest failure I could find. The documentation says that marks never had any effect on fixtures (https://docs.pytest.org/en/latest/deprecations.html#applying-a-mark-to-a-fixture-function). Running the full suite locally I saw tests using this timing out, but unsure if that's because of this missing mark (which shouldn't have been doing anything) or just general slowness.
serinamarie
added
the
development
bunchesofdonald
force-pushed
the
issue-11750-bump-pytest
branch
from
47dd43b
to
92ea4cf
Compare
bunchesofdonald
force-pushed
the
issue-11750-bump-pytest
branch
from
2e49dfe
to
40f62f0
Compare
chrisguidry
approved these changes
Feb 3, 2024
6 tasks
urimandujano
added a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit c1a3416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.