-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pytest to 8.0 #11821
Bump pytest to 8.0 #11821
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -72,7 +72,6 @@ def cleanup_all_new_docker_objects(docker: DockerClient, worker_id: str): | |||
logger.warning("Failed to clean up Docker objects") | |||
|
|||
|
|||
@pytest.mark.timeout(120) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the only specific pytest failure I could find. The documentation says that marks never had any effect on fixtures (https://docs.pytest.org/en/latest/deprecations.html#applying-a-mark-to-a-fixture-function). Running the full suite locally I saw tests using this timing out, but unsure if that's because of this missing mark (which shouldn't have been doing anything) or just general slowness.
47dd43b
to
92ea4cf
Compare
2e49dfe
to
40f62f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This reverts commit c1a3416.
No description provided.