Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring master up to 1.18.1 #1264

Merged
merged 169 commits into from
Jun 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
169 commits
Select commit Hold shift + click to select a range
b00ac0b
Speed up cold runs of PSSA by 20% by using a RunspacePool when queryi…
bergmeister Mar 16, 2019
587ac7b
Use runspace pool for rule helper for manifests as well
bergmeister Mar 16, 2019
f8e6114
Speed up cold starts of PSSA by another 35% by parallelising the expe…
bergmeister Mar 16, 2019
ce854ff
Allow case-sensitive type data collection
Mar 25, 2019
9a695c3
Fix coercion errors
Mar 25, 2019
1ff4d9f
Fix crash on duplicate assembly names
Mar 26, 2019
3b56bac
Fix asm duplicate name crash
Mar 26, 2019
cc75c62
Change logic for copying profiles into the 'install' directory (#1197)
JamesWTruher Mar 27, 2019
267f6e2
Add test for case insensitive query dictionary assembly
Mar 28, 2019
7f05870
Change module root find function in CompatibilityRule (#1196)
rjmholt Mar 28, 2019
8389997
Fix formatting regression in 1.18.0 whereby single-line pipeline redu…
bergmeister Mar 28, 2019
0e35a8a
Add suppression of warning for MS policy
JamesWTruher Apr 2, 2019
c7e9e5c
Merge pull request #1205 from JamesWTruher/suppressWarning001
JamesWTruher Apr 2, 2019
ca95a37
Fix UseCompatibleCommands doc example typo (#1204)
rjmholt Apr 3, 2019
2a73419
Fix tests
Apr 10, 2019
e818dfa
Improve tests
Apr 10, 2019
806f254
Fix UseCompatibleSyntax class error message
Apr 11, 2019
785cb3f
Apply suggestions from code review
rjmholt Apr 15, 2019
5485afc
Fix NullReferenceException for class type (#1182)
bergmeister Apr 15, 2019
071a61c
Update UseConsistentWhitespace documentation to show all options (#1185)
bergmeister Apr 15, 2019
0283f4f
Update README.md on supported PowerShell Core version and update Dock…
PrzemyslawKlys Apr 15, 2019
fa5dbe1
Speedup builds by skipping the first time initialization of the bootr…
bergmeister Apr 15, 2019
250e941
Reduce indentation level
bergmeister Apr 15, 2019
1528e99
use build pattern for less repeated code
bergmeister Apr 15, 2019
823144c
Do not use alias name as key for command info cache to fix the proble…
bergmeister Apr 16, 2019
b0399bc
Make IncreaseIndentationForFirstPipeline the true default option (#1218)
bergmeister Apr 16, 2019
82dad1a
UseCorrectCasing: Fix wildcard lookups for command lookup and do not …
bergmeister Apr 16, 2019
757e307
trigger ci
bergmeister Apr 16, 2019
08b79ca
Fix a typo (#1221)
skycommand Apr 23, 2019
3f69f93
Merge pull request #1215 from rjmholt/usecompatiblesyntax-typedef-msg
JamesWTruher Apr 23, 2019
df566b5
Merge pull request #1195 from rjmholt/case-sensitive-type-collection
JamesWTruher Apr 23, 2019
2f93ca2
Use fallback CIM API
rjmholt Mar 15, 2019
df10417
Add platform data collection type
rjmholt Mar 17, 2019
9d3c041
Add C# implementations of powershell data collection
rjmholt Mar 21, 2019
7159b8b
Add more .NET pwsh collection APIs
rjmholt Mar 23, 2019
3fcb48d
Add preliminary New-PSCompatibilityProfile cmdlet implementation
rjmholt Mar 24, 2019
85bd373
Add new cmdlets, change JSON settings, add schema version
Mar 27, 2019
528e47d
Add most validation logic
Mar 28, 2019
f7b3628
Update collectors, add assertion cmdlet
rjmholt Mar 28, 2019
8a75c91
Fix files
Mar 28, 2019
ab660e5
Fix enumeration in json cmdlet
Mar 28, 2019
d7c2169
Fix service pack
Mar 28, 2019
9e2d19b
Fix idiocy
Mar 28, 2019
565dce6
Fix generic parameter types being null
Mar 28, 2019
42d4453
Remove MMI, use registry for windows SKU info
rjmholt Mar 29, 2019
c712760
Convert scrap errors to warnings
Mar 29, 2019
28443d4
Fix error -> warning usage
Mar 29, 2019
28bb895
Fix up sku querying
Apr 8, 2019
0399922
Exclude compat module from own profiles
Apr 8, 2019
40943fb
Add copyright
Apr 8, 2019
6bdbc20
Add doc comments
Apr 8, 2019
dd2035d
Add missing docs
Apr 8, 2019
2ee3c5e
Rename PSCompatibilityAnalyzer to PSCompatibilityCollector
Apr 8, 2019
b41f0eb
Change MMI version
Apr 9, 2019
89a7ae1
Fix Get-TypeAccelerators
Apr 9, 2019
ab506af
Update validation cmdlet
Apr 9, 2019
b63a4ef
Improve cmdlet experience, add rudimentary tests
Apr 9, 2019
0d4d150
Add build error notification to build script
Apr 9, 2019
5b7f8bc
Fix NRE in type collection
Apr 9, 2019
b17418b
Don't copy profiles into published module
Apr 9, 2019
b709669
Add AzF profile
Apr 9, 2019
3be3a34
Add AzA profile
Apr 9, 2019
f00269a
Add verbose appveyor debug
Apr 9, 2019
cffe6c9
More
Apr 9, 2019
4137d91
Try again
Apr 9, 2019
7457e04
Undo module path mangling in test
Apr 10, 2019
bd8ea16
Write PSModulePath before failing test
Apr 10, 2019
97c120d
Fix parameter alias
rjmholt Apr 10, 2019
7287b40
add gmo -list display
rjmholt Apr 10, 2019
88a6a1d
Change test implementation to out-of-proc, add more printing
rjmholt Apr 10, 2019
2e8ae31
Fixup test stuff
rjmholt Apr 10, 2019
aba9e40
Fix module reloading where cmdlets are unloaded but types not
rjmholt Apr 10, 2019
470906b
Try more things
rjmholt Apr 10, 2019
fcab671
Attempt to reload and catch
rjmholt Apr 10, 2019
7198d81
Forget try/catch
rjmholt Apr 10, 2019
6235db4
More info
rjmholt Apr 10, 2019
816f0ec
Try removing first
rjmholt Apr 10, 2019
9222b52
Mark tests as pending
rjmholt Apr 10, 2019
a38373e
Remove whitespace from azure functions profile
rjmholt Apr 10, 2019
ff004d3
Use UTF-16LE for psd1
rjmholt Apr 10, 2019
fa38e1d
Change psd1 back to utf8 with bom
rjmholt Apr 10, 2019
1413c4b
Fix pester test skip
rjmholt Apr 10, 2019
a768d76
Add proper versioning to schema
Apr 10, 2019
66f92a7
Fix up namespaces
Apr 10, 2019
758db97
Fix file ending newlines
Apr 10, 2019
6d10fb0
Update schema version of azure profiles
Apr 10, 2019
eaf2ede
Fix namespaces in rules
Apr 11, 2019
a76ac6c
Rename Az profiles
Apr 11, 2019
138737d
Fix type naming namespace change
Apr 15, 2019
110a3f5
Fix syntax in AzF profile
Apr 15, 2019
dced589
Add macOS profile
rjmholt Apr 22, 2019
b700465
Prevent permissions problem reading bins for version
rjmholt Apr 22, 2019
7f57e61
Add simple command tests for AzF profile
rjmholt Apr 24, 2019
c9663ce
Add types tests
rjmholt Apr 24, 2019
2ce9992
Remove old compatibility module dir
rjmholt Apr 24, 2019
cf97e0b
Add rule enable settings
rjmholt Apr 24, 2019
234fae4
Fix grouping logic
rjmholt Apr 24, 2019
4f8e34e
Add example to illustrate behavior (#1220)
awsles Apr 24, 2019
808a7eb
Add breaks to switch
rjmholt Apr 24, 2019
e65d011
Make negative group name test more diagnostic
rjmholt Apr 24, 2019
f04009d
Refine empty group test
rjmholt Apr 24, 2019
1c78a6b
Fix other test
rjmholt Apr 24, 2019
9f6ef22
Remove faulty test component
rjmholt Apr 24, 2019
69c483c
Fix encoding of test files
rjmholt Apr 24, 2019
54a4bb2
Fix documentation examples of new UseCompatible* rules (#1225)
bergmeister Apr 24, 2019
6447bf8
Update PossibleIncorrectComparisonWithNull.md
PrzemyslawKlys Apr 24, 2019
0bbf54f
Address @JamesWTruher's feedback
rjmholt Apr 25, 2019
db6cd7b
Fix ConvertFrom-PSCompatibilityJson for loop
rjmholt Apr 26, 2019
41007f6
Fix compatibility profile label typo (#1229)
rjmholt Apr 30, 2019
b458bbb
Remove code for deprecated rules that is not used any more
bergmeister May 3, 2019
0620491
Prevent crash if hashtable definition start on first token and there …
bergmeister May 4, 2019
7a3688e
Fix typo in AvoidDefaultValueForMandatoryParameterError resource stri…
ThomasNieto May 5, 2019
1cdd33c
Instead of using the first cimClass and then having no superClass, us…
bergmeister May 5, 2019
064b622
Merge pull request #1212 from rjmholt/azf-compat
JamesWTruher May 10, 2019
b5648de
Merge pull request #1232 from bergmeister/removeDeprecatedRules
JamesWTruher May 16, 2019
9a557de
Merge pull request #1226 from PrzemyslawKlys/patch-1
JamesWTruher May 16, 2019
fd4d8a3
Fix compatibility alias resolution
Mar 25, 2019
6c0d594
Fix NRE
Mar 25, 2019
a3c9251
Address @bergmeister's feedback
Mar 28, 2019
23e1051
Add tests for engine cmdlet aliases
rjmholt Apr 24, 2019
64b77fb
Merge pull request #1194 from rjmholt/compat-aliases
JamesWTruher May 28, 2019
adb5089
Update PossibleIncorrectComparisonWithNull documentation with better …
bergmeister May 29, 2019
19b315d
Add test that should fail on Linux first (TDD)
bergmeister May 30, 2019
c34ff8f
Fix TDD test and make code more x-plat compliant to fix some ModuleDe…
bergmeister May 30, 2019
4f26261
Update RuleDocumentation/PossibleIncorrectComparisonWithNull.md
bergmeister May 30, 2019
1901be3
Add example from Jim
bergmeister May 30, 2019
2758de2
Enable ModuleDependencyHandler.tests.ps1 Pester tests on Linux (I exp…
bergmeister May 30, 2019
9a2f490
make some tests runnable in ModuleDependencyHandler.tests.ps1 and che…
bergmeister May 31, 2019
908cd3a
cleanup and do not run test in WMF4
bergmeister May 31, 2019
1261df2
fix tests on Linux
bergmeister May 31, 2019
46ac068
Change build script to install into a versioned directory
JamesWTruher May 31, 2019
787bd8a
Fix typo in normalized savedPSModulePath
JamesWTruher May 31, 2019
e646c8f
Change logic for running tests on PSv3 and PSv4
JamesWTruher May 31, 2019
6c6ff43
update appveyor Invoke-AppveyorTest to match how we run tests in buil…
JamesWTruher May 31, 2019
8a3887a
additional debugging output for appveyor build
JamesWTruher May 31, 2019
cbb59cf
more debugging statements
JamesWTruher May 31, 2019
41a2ea1
Remove debugging statements
JamesWTruher Jun 2, 2019
6c946c0
Merge pull request #1247 from JamesWTruher/VersionBuild
JamesWTruher Jun 3, 2019
f5b8461
bump version to 1.18.1
bergmeister Jun 3, 2019
f3608bf
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jun 3, 2019
8fa6612
Add ImplementingType to RuleInfo object
JamesWTruher Jun 4, 2019
05cf516
Add a test for the new behavior
JamesWTruher Jun 4, 2019
8d91e1e
Fix logic errors in AvoidAlias rule
JamesWTruher Jun 5, 2019
1781717
Update Rules/AvoidAlias.cs
JamesWTruher Jun 5, 2019
9d19209
Merge pull request #1251 from JamesWTruher/avoidaliasfix001
JamesWTruher Jun 5, 2019
29d99cb
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jun 5, 2019
c7ac69e
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jun 5, 2019
3c56ee1
Adapt tests so that they pass the first time when being run the first…
bergmeister Jun 5, 2019
039c700
Merge pull request #1178 from bergmeister/Performance_RunspacePool_An…
JamesWTruher Jun 5, 2019
a9b3d64
Merge pull request #1248 from bergmeister/versionbump_18_1
JamesWTruher Jun 5, 2019
a7dbee1
Merge pull request #1250 from JamesWTruher/RuleInfoEnhancement001
JamesWTruher Jun 5, 2019
c23bf1c
Merge pull request #1244 from PowerShell/bergmeister-docs-1
JamesWTruher Jun 5, 2019
868640d
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Jun 5, 2019
098139f
improve test as per PR review
bergmeister Jun 5, 2019
36ee8c0
update signing file for versioned location of module
JamesWTruher Jun 5, 2019
ab0fc4f
Merge pull request #1253 from JamesWTruher/vsts-1.18.1
JamesWTruher Jun 6, 2019
84f433a
Merge pull request #1246 from bergmeister/SaveDscDependencyOnLinux
JamesWTruher Jun 6, 2019
6c891b6
UseCorrectCasing: Preserve script paths
bergmeister Jun 6, 2019
c3f2a20
Merge pull request #1235 from bergmeister/CloseBraceFix
JamesWTruher Jun 6, 2019
3770023
make test ps v4 compatible (new-guid cmdlet does not exists on v4)
bergmeister Jun 6, 2019
c8feb9c
Add test case for general paths
bergmeister Jun 6, 2019
069d02f
Add test case for application paths as discussed and do not correct a…
bergmeister Jun 6, 2019
6008087
Make it possible to build ScriptAnalyzer with PowerShell7
bergmeister Jun 7, 2019
0bef1c8
Merge pull request #1256 from bergmeister/BuildWithPowerShell7
JamesWTruher Jun 7, 2019
f99e1f4
Enable suppression of custom rules when used together with -IncludeDe…
bergmeister Jun 11, 2019
9320a74
Use environment variable to get Windows directory to address PR feedback
bergmeister Jun 11, 2019
b09eb33
Lock calls around Test-ModuleManifest, which is not thread safe (#1258)
bergmeister Jun 12, 2019
2cc40ec
Merge pull request #1255 from bergmeister/DoNotCorrectCasingOfFilePaths
JamesWTruher Jun 12, 2019
e206b32
CHANGELOG for 1.18.1 (#1259)
bergmeister Jun 12, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -216,5 +216,5 @@ PSScriptAnalyzer/
# Test result file
TestResults.xml

# PSCompatibilityAnalyzer module
PSCompatibilityAnalyzer/out/
# PSCompatibilityCollector module
PSCompatibilityCollector/out/
58 changes: 58 additions & 0 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
@@ -1,5 +1,63 @@
# CHANGELOG

## [1.18.1](https://github.com/PowerShell/PSScriptAnalyzer/tree/1.18.1) - 2019-06-12

### Fixes

- Formatter
- UseCorrectCasing
- Do not use alias name as key for command info cache to fix the problem where UseCorrectCasing corrects aliases (#1216) (by @bergmeister)
- Fix wildcard lookups for command lookup and do not append .exe for applications on Windows (#1210) (by @bergmeister)
- Do not correct applications or script paths at all (#1255) (by @bergmeister)
- Prevent PSCloseBrace crash if hashtable definition start on first token and there is a PSCloseBrace violation (#1235) (by @bergmeister)
- PipelineIndentationStyle
- Fix formatting regression in 1.18.0 whereby single-line pipeline reduces indentation level incorrectly (#1191) (by @bergmeister)
- Make IncreaseIndentationForFirstPipeline the true default option for PipelineIndentationStyle option (#1218) (by @bergmeister)

- Compatibility Rules
- Fix UseCompatibleSyntax class error message (#1215) (by @rjmholt)
- Convert compatibility module to binary module, fix compatibility with Azure environments (#1212) (by @rjmholt)
- Prevent .NET members with names differing only by case from crashing the compatibility profiler (#1195) (by @rjmholt)
- Fix compatibility profile query API so that aliases referring to other modules appear (#1194) (by @rjmholt)

- DSC
- Instead of using the first cimClass and then having no superClass, use the first cimClass that has a non-null superClass (#1200) (by @bergmeister, thanks to @ykuijs! for the great collaboration)
- Make `-SaveDscDependency` work on Linux (#1246) (by @bergmeister)

- Enable suppression of custom rules when used together with `-IncludeDefaultRules` to allow all possible scenarios from 1.17.1 and 1.18.0. This removes also the check if the rule name in the suppression attribute can be found because this check is technically not possible in all scenarios (#1245) (by @bergmeister)
- Fix NullReferenceException for class type (#1182) (by @bergmeister)

### Performance

2 improvements were made that make cold runs of ScriptAnalyzer twice as fast compared to `1.18.0`

- Speedup cold runs by using a runspace pool (#1178) (by @bergmeister)
- Fix logic errors in AvoidAlias rule to halve the amount of necessary calls to `Get-Command`, making the rule twice (#1251) (by @JamesWTruher)

### General Improvements

- Add ImplementingType to RuleInfo object for better settings file validation and settings template file creation (#1250) (by @JamesWTruher)
- Fix typo in AvoidDefaultValueForMandatoryParameterError resource string (#1233) (Thanks @tnieto88!)
- Change module root find function in CompatibilityRule (#1196) (by @rjmholt)

### Documentation

- Update PossibleIncorrectComparisonWithNull documentation with better example (#1244, #1226 and #1220) (by @bergmeister and thanks to @PrzemyslawKlys and @lesterw1!)
- Compatibility rules documentation fixes (#1229, #1204, #1225 and #1221) (by @rjmholt, @bergmeister and thanks @skycommand!)
- Update README.md on supported PowerShell Core version and update Docker examples (#1188) (Thanks @PrzemyslawKlys!)
- Update UseConsistentWhitespace documentation to show all options (#1185) (by @bergmeister)

### Build

- Make it possible to build ScriptAnalyzer with PowerShell7 (#1256) (by @bergmeister)
- Update signing file for versioned location of module (#1253) (by @JamesWTruher)
- Bump version to 1.18.1 (#1248) (by @bergmeister)
- Change build script to install into a versioned directory (#1247) (by @JamesWTruher)
- Remove code for deprecated rules that is not used any more (#1232) (by @bergmeister)
- Speedup CI builds by skipping the first time initialization of the bootstrapped dotnet CLI (#1211) (by @bergmeister)
- Add suppression of warning for MS policy (#1205) (by @JamesWTruher)
- Change logic for copying profiles into the 'install' directory (#1197) (by @JamesWTruher)

## [1.18.0](https://github.com/PowerShell/PSScriptAnalyzer/tree/1.18.0) - 2019-03-21

### Breaking Changes
Expand Down
156 changes: 0 additions & 156 deletions DeprecatedRules/AvoidUninitializedVariable.cs

This file was deleted.

131 changes: 0 additions & 131 deletions DeprecatedRules/AvoidUnloadableModule.cs

This file was deleted.

Loading