bring master up to 1.18.1 #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng PowerShell for CommandInfo. There are only 4 rules that could call the CommandInfoCache, therefore sizing the pool to 5. The pool creation is synchronous and adds 15ms of initialization overhead, which we can neglect I think.
…nsive command lookup in AvoidAlias, which is the most expensive rule. To accomodate the higher parallel demand, increase runspace pool.
Multiple runs would result in incorrect layout of the compatibility profiles
* Change module root find function * Fix whitespace * Add a comment
…ces indentation level incorrectly (#1191) * Fix issue whereby single-line pipeline reduces indentation level incorrectly (problem only showed up when there was already existing indentation due to ClipNegative * Apply suggestions from code review Co-Authored-By: bergmeister <[email protected]> * Fix tests by replacing break with continue (forgot I was inside for loop and not switch statement), simple mistake
Because we are using a direct invocation of ConvertTo-SecureString it triggers a warning by MS tools that secrets are not allowed to be checked in to our repository. This suppresses this warning.
Add suppression of warning for MS policy
Co-Authored-By: bergmeister <[email protected]>
* Fix NullReferenceException for class type * Add regression test * Address PR comments: add comment where the special case can happen and simplify test case to one-liner
…er examples (#1188) * Update README.md An updated version of PowerShell Core from 6.0.2 to 6.1.0 as per Changelog * Update PowerShell Core docker info for Windows * update linux images as well
…apped dotnet CLI (#1211)
…m where UseCorrectCasing corrects aliases (#1216) * Do not use alias name as key for command info cache to fix the problem where UseCorrectCasing corrects aliases * Remove unused aliasName parameter and left-over GetCommandInfoInternal function from refactoring a few weeks ago
…append .exe for applications on Windows (#1210) * UseCorrectCasing: Fix special case of ? for command lookup and do not correct application names to end in .exe on Windows * Use more generic WildcardPattern.Escape method * Remove application extension more generically and on Windows only * Make applications with an extension preserver the extension and re-use isWindows variable better * Apply suggestions from code review Co-Authored-By: bergmeister <[email protected]>
This is a proposal for fixing what I perceive to a typo. I recommend an expert should look at this first.a
Fix UseCompatibleSyntax class error message
Co-Authored-By: Christoph Bergmeister [MVP] <[email protected]>
Fix logic errors in AvoidAlias rule
…nalyzer into Performance_RunspacePool_AndSpeedupAvoidAlias Resolved by taking upstream changes # Conflicts: # Rules/AvoidAlias.cs
…nalyzer into SaveDscDependencyOnLinux
… time. There is more cleanup needed in this class in general but this is the minimum viable change
…dSpeedupAvoidAlias Speedup cold runs of PSSA by using a runspace pool and parallelizing the slowest rule (AvoidAlias)
Bump version to 1.18.1
Add ImplementingType to RuleInfo object
Update PossibleIncorrectComparisonWithNull documentation with better example
update signing file for versioned location of module
-SaveDscDependency on Linux
Prevent PSCloseBrace crash if hashtable definition start on first token and there is a PSCloseBrace violation
…pplication paths any more for simplicity
Make it possible to build ScriptAnalyzer with PowerShell7
…faultRules (#1245) * remove faulty error checking * fix syntax error * Add test cases * cleanup * remove resource string of error message * Make tests PS4 compatible
UseCorrectCasing: Do not correct applications or script paths at all
* CHANGELOG for 1.18.1 * update changelog * Update CHANGELOG.MD
bergmeister
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
With the release of 1.18.1, we need to bring the master branch up to date
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.