myql and sqlite3 schema path/filename variable add #98
Conversation
|
Looks good, please add the new variables in the Readme.md |
tasks/database-sqlite3.yml
Outdated
| @@ -52,7 +38,7 @@ | |||
| - block: | |||
|
|
|||
| - name: Create the PowerDNS SQLite databases on Debian | |||
| shell: "sqlite3 {{ item }} < /usr/share/doc/pdns-backend-sqlite3/schema.sqlite3.sql" | |||
| shell: "sqlite3 {{ item }} < {{ pdns_deb_sqlite3_schema_file }}" | |||
There was a problem hiding this comment.
I don't see why we'd have a separate variable name for each distro type, this is why we have the vars file that set this. I would prefer to have a pdns_sqlite3_schema_file (etc.) that are set in the vars by defaults.
There was a problem hiding this comment.
If I get it well you propose just two (sqlite3 and mysql schemas variables) in the defaults/main.yml file that will look like the following. Correct?
pdns_mysql_schema_file: "/usr/share/doc/pdns-backend-mysql/schema.mysql.sql"
pdns_sqlite3_schema_file: "/usr/share/doc/pdns-backend-sqlite3/schema.sqlite3.sql"
There was a problem hiding this comment.
Indedd, whose values are set via an underscore var from the vars/* files
…riable per db. No more switch case for different db engine version
In order to avoid problems with the previous rules that forged the path/filename for the DB schema switching by case for different platform/version etc. I am proposing a fixed variable way to setup the path/filename using eg. vars/Debian.yml line entry.
Case one will be for ArchLinux platform case two for RH and Debian/Ubuntu platform.
In every case we have a different schema filename for mysql or sqlite3 obviously.