Fix schema detection, testing #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterlexis
force-pushed
the
fix-tests-tox
branch
2 times, most recently
from
46d7405
to
00b16f2
Compare
|
For some reason, I don't see the GH actions here. But you can find them here: https://github.com/pieterlexis/pdns-ansible/actions |
giannipace
reviewed
Jun 16, 2021
pieterlexis
force-pushed
the
fix-tests-tox
branch
from
00b16f2
to
7554c94
Compare
SrX
approved these changes
Jun 21, 2021
giannipace
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all the tests and switches from Travis to GH actions.
More importantly, it now uses a small shell command on the target host to find the schema instead of relying on ansible variables or a static variable (although an override with a static var is possible).
Closes #98
Closes #92
CC: @npmdnl