Tooltips: sort by count and fix render issue #8046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
reviewed
Jan 14, 2022
paolodamico
suggested changes
Jan 18, 2022
There was a problem hiding this comment.
This is definitely an improvement and I wouldn't be opposed to merging. However, I don't think this is the best solution. Consider this extreme case, tooltips are impossible to read. I would add an upper bound on how wide/tall (depending on row/column) the tooltip can be, and ellipsis the text there (maybe 2-3 rows). Everything else lgtm!
|
Thanks for the review, this should fix it to 2 rows.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2620
Fixes #8014
wow look at that ~6K issue number difference
How did you test this code?
Stylistic changes