Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order metrics shown on tooltip #2620

Closed
macobo opened this issue Dec 2, 2020 · 4 comments · Fixed by #8046
Closed

Order metrics shown on tooltip #2620

macobo opened this issue Dec 2, 2020 · 4 comments · Fixed by #8046
Assignees
Labels
enhancement New feature or request feature/trends Feature Tag: Trends

Comments

@macobo
Copy link
Contributor

macobo commented Dec 2, 2020

Is your feature request related to a problem?

This tooltip is hard to follow:

Screenshot from 2020-12-02 10-53-19

Describe the solution you'd like

Order the tooltip by volume somehow.

One potential ordering - take the last data point, order by that.

Describe alternatives you've considered

Additional context

Not sure why versions which are at 0 every datapoint even show up.

Came up during #2560

Thank you for your feature request – we love each and every one!

@macobo macobo added enhancement New feature or request UI/UX feature/trends Feature Tag: Trends labels Dec 2, 2020
@macobo
Copy link
Contributor Author

macobo commented Dec 2, 2020

Not sure why versions which are at 0 every datapoint even show up.

This is coming from the backend - TOP_ELEMENTS_ARRAY_OF_KEY_SQL is returning all possible values in time frame, ignoring all other filters.

@EDsCODE would it be reasonable to add filter clause to TOP_ELEMENTS_ARRAY_OF_KEY_SQL as well?

Also, should we also sort the result from backend to solve this issue?

@EDsCODE
Copy link
Member

EDsCODE commented Dec 2, 2020

Yeah, I think we should add filters clause to that SQL and for TOP_PERSON_PROPS_ARRAY_OF_KEY_SQL

@paolodamico
Copy link
Contributor

Relevant user feedback (Slack), optionally hide 0 or null values.

@Twixes
Copy link
Collaborator

Twixes commented Jan 12, 2022

This is solved in the current production tooltips BUT not in the latest line-graph-v2 iteration @alexkim205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/trends Feature Tag: Trends
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants