Make saved insights meta fields editable in-line

[alexkim205]

Changes

Closes #6131.

Should've gotten most of the edge cases with different types of inputs but please feel free to poke around and break things.

Demo

Screen.Recording.2021-10-04.at.12.45.03.AM.mov

How did you test this code?

• tests for new logics
• tests for new utils

[pauldambra]

Looks good to me 🙌 . No reason to block this merge on the idea of extracting a component from the editable text although (if nothing else) it does save the future reader comparing the title and description to understand differences

[clarkus]

I like this change. Based on the feedback during the demo today, we might consider making renaming, description editing, tagging available outside of the edit view. Is it technically feasible to save those single-attribute changes outside the edit workflow? Great work, Alex!

[alexkim205]

Thanks for the feedback everyone!

Is it technically feasible to save those single-attribute changes outside the edit workflow?

Yup it should be. The only difference would be if the user clicks "Done" outside of the edit workflow, it will permanently save the metadata for that insight. This is different from behavior in the edit workflow, where clicking "Done" will just save the state of the metadata and clicking "Save" will permanently save the final state.

[alexkim205]

Added edit functionality to view modes and cleaned up FF's for this feature.

Screen.Recording.2021-10-04.at.4.19.09.PM.mov

addressed feedback

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@25163d0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6159   +/-   ##
=========================================
  Coverage          ?   91.77%           
=========================================
  Files             ?      391           
  Lines             ?    29584           
  Branches          ?     2510           
=========================================
  Hits              ?    27150           
  Misses            ?     1906           
  Partials          ?      528           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25163d0...8300128. Read the comment docs.

[mariusandra]

Overall LGTM. Going to merge since I want to work on the insight logics a bit today, and best to have it in... and it's feature flagged.

The twothree UX issues I found here are:

1. Editing tags inside the "view" mode doesn't save them
2. When I reload the insight, sometimes I see the edited text, sometimes not.
3. Sometimes I get to a state where it creates a new insights on every reload

All these are proper blockers to unflagging saved insights, but not for merging this PR.