Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Layout button on saved insights #6048

Merged

Conversation

alexkim205
Copy link
Contributor

Changes

Part of #6036 saved insights initiative.

Before

Screen Shot 2021-09-20 at 4 17 45 PM

After

Screen Shot 2021-09-20 at 4 15 42 PM

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@alexkim205 alexkim205 mentioned this pull request Sep 20, 2021
7 tasks
@alexkim205 alexkim205 self-assigned this Sep 20, 2021
@timgl timgl temporarily deployed to posthog-pr-6048 September 20, 2021 23:20 Inactive
@alexkim205 alexkim205 merged commit 9ca16fb into fix/saved-insights-bugs-6036 Sep 20, 2021
@alexkim205 alexkim205 deleted the fix/better-lookin-layout-buttons branch September 20, 2021 23:29
@alexkim205 alexkim205 mentioned this pull request Sep 21, 2021
14 tasks
mariusandra pushed a commit that referenced this pull request Sep 23, 2021
* Cleanup Insights.tsx (#6037)

* refactors a bunch of stuff out of Insights.tsx into a separate component

* use view map

* make funnels full width (#6039)

* Add CTA empty state to saved insights page (#6042)

* add cta for empty saved insights table

* refactor

* Add descriptive headers to Saved Insights View/Edit/Create modes (#6045)

* add header to insight graphs and styling

* remove console

* Use radio instead of buttons (#6048)

* Split person asynchronously (#5992)

* docs(events): add documentation on index on posthog_event.distinct_id (#5973)

* use displaymaps in saved insights (#6047)

* add loading state and fix person modal not showing bug

Co-authored-by: Tim Glaser <[email protected]>
Co-authored-by: Harry Waye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants