Allow to configure the HttpClient maximumBackoffDuration #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eexit
force-pushed
the
master
branch
4 times, most recently
from
5d32dbe to
8f1d2aa
Compare
allan-simon
reviewed
May 20, 2022
|
Hello, any update on when this could be merged/released? Thanks! |
|
@EDsCODE is it possible to have your opinion on this PR ? :) |
|
This destroyed prod for me today. This definitely needs to be configurable. |
|
Using |
EDsCODE
approved these changes
Mar 8, 2023
|
@EDsCODE Are you aware of any caveats using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I work with @allan-simon, who reported this issue, and reducing the timeout is a bit useless if there's a retry mechanism we can't configure.
Our integration is sync so we can't afford blocking 17s+ for a retry that will most likely fail anyway.
The do/while is for when I want to set
maximum_backoff_durationto0, so it could at least try once.