Allow to configure the HttpClient maximumBackoffDuration

PostHog · May 20, 2022 · 961baf9 · 961baf9
1 parent 2d42699
commit 961baf9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/lib/Client.php b/lib/Client.php
@@ -53,7 +53,7 @@ public function __construct(string $apiKey, array $options = [], ?HttpClient $ht
         $this->httpClient = $httpClient !== null ? $httpClient : new HttpClient(
             $options['host'] ?? "app.posthog.com",
             $options['ssl'] ?? true,
-            10000,
+            (int) ($options['maximum_backoff_duration'] ?? 10000),
             false,
             $options["debug"] ?? false
         );

diff --git a/lib/HttpClient.php b/lib/HttpClient.php
@@ -68,9 +68,9 @@ public function sendRequest(string $path, ?string $payload, array $extraHeaders
     {
         $protocol = $this->useSsl ? "https://" : "http://";
 
-        $backoff = 100;     // Set initial waiting time to 100ms
+        $backoff = 100; // Set initial waiting time to 100ms
 
-        while ($backoff < $this->maximumBackoffDuration) {
+        do {
             // open connection
             $ch = curl_init();
 
@@ -115,7 +115,7 @@ public function sendRequest(string $path, ?string $payload, array $extraHeaders
             } else {
                 break;  // no error
             }
-        }
+        } while ($backoff < $this->maximumBackoffDuration);
 
         return $httpResponse;
     }

diff --git a/lib/PostHog.php b/lib/PostHog.php
@@ -6,7 +6,7 @@
 
 class PostHog
 {
-    public const VERSION = '2.1.0';
+    public const VERSION = '2.1.1';
     public const ENV_API_KEY = "POSTHOG_API_KEY";
     public const ENV_HOST = "POSTHOG_HOST";
 

diff --git a/lib/QueueConsumer.php b/lib/QueueConsumer.php
@@ -30,6 +30,10 @@ public function __construct($apiKey, $options = array())
             $this->batch_size = $options["batch_size"];
         }
 
+        if (isset($options["maximum_backoff_duration"])) {
+            $this->maximum_backoff_duration = (int) $options["maximum_backoff_duration"];
+        }
+
         if (isset($options["host"])) {
             $this->host = $options["host"];