Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow decide to provide script name for recorder #1509

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

pauldambra
Copy link
Member

we want to allow specifying the name of the recorder script so we can roll out changes without affecting everyone all at once

this lets us use the decide response to specify the script name for the lazy loaded recorder

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 28, 2024 4:26pm

@pauldambra pauldambra requested a review from a team November 2, 2024 12:34
@pauldambra pauldambra added the bump minor Bump minor version when this PR gets merged label Nov 2, 2024
Copy link

github-actions bot commented Nov 2, 2024

Size Change: +2.86 kB (+0.09%)

Total Size: 3.18 MB

Filename Size Change
dist/array.full.es5.js 258 kB +305 B (+0.12%)
dist/array.full.js 361 kB +284 B (+0.08%)
dist/array.full.no-external.js 360 kB +284 B (+0.08%)
dist/array.js 175 kB +284 B (+0.16%)
dist/array.no-external.js 174 kB +284 B (+0.16%)
dist/main.js 176 kB +284 B (+0.16%)
dist/module.full.js 361 kB +284 B (+0.08%)
dist/module.full.no-external.js 360 kB +284 B (+0.08%)
dist/module.js 175 kB +284 B (+0.16%)
dist/module.no-external.js 174 kB +284 B (+0.16%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.5 kB
dist/dead-clicks-autocapture.js 14.3 kB
dist/exception-autocapture.js 9.37 kB
dist/external-scripts-loader.js 2.29 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@pauldambra
Copy link
Member Author

towards PostHog/posthog#25721

@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Collaborator

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@pauldambra pauldambra reopened this Nov 20, 2024
@posthog-bot posthog-bot removed the stale label Nov 21, 2024
@posthog-bot
Copy link
Collaborator

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@pauldambra pauldambra changed the title feat: allowd decide to provide script name for recorder feat: allow decide to provide script name for recorder Nov 28, 2024
@pauldambra pauldambra removed the stale label Nov 28, 2024
@pauldambra pauldambra merged commit 2186b6e into main Nov 28, 2024
13 checks passed
@pauldambra pauldambra deleted the feat/allow-different-scripts branch November 28, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants