Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow alternative recorder script names #25961

Merged
merged 15 commits into from
Nov 28, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Nov 2, 2024

we want to allow specifying the name of the recorder script so we can roll out changes without affecting everyone all at once

this lets us use environment variables to specify an alternative name and a set of teams that should receive it

i've confirmed locally this works when paired with PostHog/posthog-js#1509

@pauldambra pauldambra requested a review from a team November 2, 2024 12:32
Comment on lines +367 to +369
rrweb_script_config = {
"script": settings.SESSION_REPLAY_RRWEB_SCRIPT,
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slightly over careful in returing a structure rather than a value in case this changes over time e.g. loading from a different host

@pauldambra
Copy link
Member Author

towards #25721

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@pauldambra pauldambra reopened this Nov 20, 2024
@pauldambra pauldambra removed the stale label Nov 20, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra requested a review from a team November 28, 2024 13:29
Copy link
Contributor

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand much, but I see some test there :)

@pauldambra pauldambra enabled auto-merge (squash) November 28, 2024 13:34
@pauldambra pauldambra merged commit ca60551 into master Nov 28, 2024
91 checks passed
@pauldambra pauldambra deleted the feat/allow-alternative-recorder-script-names branch November 28, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants