$active_feature_flags should filter non active flags
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
approved these changes
Oct 6, 2023
I made sure to run locally on an emulator, so it's fine, let me check if it's easy to set up a mock HTTP cal, etc. |
|
not a requirement! happy as long as it works, given you're going to revamp soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Similar to this one PostHog/posthog-android#41
Closes PostHog/posthog-android#40
Where should the reviewer start?
How should this be manually tested?
there is no unit test at all for that, I will add in the new version of the iOS SDK, but for now this should be fine.
Any background context you want to provide?
decide v3 returns all the feature flags and not only the active ones
What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions: