Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$active_feature_flags should filter non active flags #40

Closed
marandaneto opened this issue Oct 6, 2023 · 0 comments · Fixed by #41 or PostHog/posthog-ios#73
Closed

$active_feature_flags should filter non active flags #40

marandaneto opened this issue Oct 6, 2023 · 0 comments · Fixed by #41 or PostHog/posthog-ios#73
Labels
bug Something isn't working Feature Flags

Comments

@marandaneto
Copy link
Member

Description

https://github.com/PostHog/posthog-js/pull/616/files#diff-8af751c29c92de49f1220a34f3293d52755a0faacb360d38838065084a97c8ebR24-R33

iOS code has to be fixed as well: https://github.com/PostHog/posthog-ios/blob/aab0004088fc17b8da88a0e43b37181773408ce2/PostHog/Internal/PHGPostHogIntegration.m#L653-L657

As long as it's not false, it's considered active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Feature Flags
Projects
None yet
Milestone
No milestone
1 participant
@marandaneto