Upgrade to 2.0.0-preview2 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
caleblloyd
commented
Jul 3, 2017
caleblloyd
commented
- Fixes Upgrade to 2.0.0-preview #282
- Once this is in Master we can get MyGet publishing Pre Releases again
- This should have all of the same features as 1.1.2
- Only functional test still failing is due to Including collection navigation after optional navigation throws NRE with async in 2.0.0 dotnet/efcore#9038 and will fix once resolved upstream
Fixes migration unit tests
Fix value generation
Finish upgrade to EFCore 2.0.0-preview2
yukozh
requested changes
Jul 3, 2017
.travis.yml
Outdated
| @@ -13,15 +13,18 @@ branches: | |||
|
|
|||
| before_install: | |||
| - docker run --name mysql -e MYSQL_ROOT_PASSWORD=Password12! -d mysql:5.7 | |||
| - docker run -v $(pwd):/dotnet/:rw -e 'CI=True' --name dotnet --link mysql:mysql -d microsoft/dotnet:1.1.1-sdk sh -c 'while true; do sleep 0.1; done' | |||
| - docker run -v $(pwd):/dotnet/:rw -e 'CI=True' --name dotnet --link mysql:mysql -d microsoft/dotnet:2.0.0-preview1-sdk sh -c 'while true; do sleep 0.1; done' | |||
build-run.ps1
Outdated
| $dotnetSharedRuntimeChannel = "rel-1.0.0" | ||
| $dotnetArch = 'x64' | ||
| $dotnetChannel = "preview" | ||
| $dotnetVersion = "2.0.0-preview1-005957" |
| & "$buildFolder\dotnet\dotnet-install.ps1" -Channel $dotnetSharedRuntimeChannel -SharedRuntime -Version $dotnetSharedRuntimeVersion -Architecture x64 | ||
| } | ||
| & "$buildFolder\dotnet\dotnet-install.ps1" -Channel $dotnetChannel -Version $dotnetVersion -Architecture $dotnetArch | ||
| InstallSharedRuntime -version "1.1.2" -channel "release/1.1.0" |
| @@ -0,0 +1,29 @@ | |||
| using JetBrains.Annotations; | |||
| @@ -0,0 +1,17 @@ | |||
| // Copyright (c) Pomelo Foundation. All rights reserved. | |||
| namespace Microsoft.EntityFrameworkCore.Metadata | ||
| { | ||
| public interface IMySqlIndexAnnotations : IRelationalIndexAnnotations | ||
| { | ||
| string Method { get; } |
There was a problem hiding this comment.
I think we should support hash and btree instead of these.
There was a problem hiding this comment.
That could be handled in a separate PR
| @@ -0,0 +1,10 @@ | |||
| // Copyright (c) Pomelo Foundation. All rights reserved. | |||
| /// This API supports the Entity Framework Core infrastructure and is not intended to be used | ||
| /// directly from your code. This API may change or be removed in future releases. | ||
| /// </summary> | ||
| public const string Clustered = Prefix + "Clustered"; |
| /// This API supports the Entity Framework Core infrastructure and is not intended to be used | ||
| /// directly from your code. This API may change or be removed in future releases. | ||
| /// </summary> | ||
| public new virtual bool IsClustered(bool? value) => SetIsClustered(value); |
| { | ||
| } | ||
|
|
||
| public virtual bool? IsClustered |
yukozh
approved these changes
Jul 3, 2017
|
Thanks I'll fix these and get MyGet running tomorrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.