Fixes migration unit tests #293
Conversation
|
@caleblloyd Did the UT in your machine can pass 43 cases? or you can only pass 7 cases now? The EF core always connect to a incorrect connection string to get the mysql version. |
|
I think I need to switch the Connection Settings to do a lazy initialize |
|
In this way, the migrations will be mitigated now, but on update will be broken. I will keep investigate the next days. I was too busy in previous term to maintain this project. Thanks for your contributions these days. |
|
@caleblloyd Now the UT fails 3 cases only. I want to checkin this first and fix them later. What's your thoughts? |
| $"Error in {table}.{name}: DATETIME does not support values generated " + | ||
| "on Add or Update in MySql <= 5.5, try explicitly setting the column type to TIMESTAMP"); | ||
| } | ||
| catch { |
There was a problem hiding this comment.
We should not catch and ignore this. Instead we should mock ConnectionSettings in the UT so it doesn't fail
|
Removed try catch will throw an exception, could you investigate this? @caleblloyd |
|
Yes I'll work up a mock options |
|
@caleblloyd Does pomelo 2.0 not work? I've gotten an exception: Unhandled Exception: System.ArgumentNullException: Value cannot be null. |
No description provided.