Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #950: Add missing 'stat_changes' to moves #954

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

JintoYamanaka
Copy link
Contributor

This pull request addresses the issue #950 by adding the missing 'stat_changes' data for the moves Stockpile, Memento, Defog, and Shell Smash.

Changes:

  • Stockpile: Increases Defense and Special Defense by 1 rank each.
  • Memento: Decreases the target's Attack and Special Attack by 2 ranks each.
  • Defog: Reduces the target's evasion by 1 rank.
  • Shell Smash: Increases user's Attack, Special Attack, and Speed by 2 ranks, decreases Defense and Special Defense by 1 rank each.

Testing:

  • Verified that the updated move data reflects the correct stat_changes.

Please review the changes and let me know if any further modifications are required.
Thank you for considering this contribution to the PokeAPI project.

JintoYamanaka and others added 2 commits November 8, 2023 20:52
Included the missing 'stat_changes' for Stockpile, Memento, Defog, and Shell Smash to accurately reflect their in-game effects.
@Naramsim Naramsim merged commit 0dfb20d into PokeAPI:master Nov 8, 2023
2 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants