Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves missing 'stat_changes' entries #950

Closed
joelesbennett opened this issue Nov 1, 2023 · 7 comments
Closed

Moves missing 'stat_changes' entries #950

joelesbennett opened this issue Nov 1, 2023 · 7 comments

Comments

@joelesbennett
Copy link
Contributor

joelesbennett commented Nov 1, 2023

Stockpile, Memento, Defog and Shell Smash are all missing stat_changes. Since these moves all result in stat changes on every use (barring if stats are at max or min modifier), seems like this data could be present but perhaps this is deliberately not there?

@Naramsim
Copy link
Member

Naramsim commented Nov 2, 2023

Could you help us and fill in the missing data into our CSV files? Thanks!

@JintoYamanaka
Copy link
Contributor

@Naramsim @joelesbennett
Hi.
I too noticed that "stat_changes" in "Shell Smash" is empty and just want to fix it.

May I fix it all together?

@Naramsim
Copy link
Member

Naramsim commented Nov 8, 2023

Go for it

@joelesbennett
Copy link
Contributor Author

Hi both,

Sorry I missed the replies! @JintoYamanaka sounds good, I was unlikely to get to it in the next couple days now anyway!

Thanks!

@JintoYamanaka
Copy link
Contributor

I have created Pull Request in response to this issue.
I would appreciate it if you could consider reviewing and merging it.

@Naramsim
Copy link
Member

Hi is the issue solved?

@JintoYamanaka
Copy link
Contributor

Hi, I've confirmed that the fixes have been reflected in the production environment.
I'm unable to close this issue, so could you close it? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants