Fix/clean transfert permissions ALL TO MONTORING_XXX

[amandine-sahl]

Lors de la migration alembic, la répercussion de la gestion des permissions (avec des sous_objets) utilisait une fonction.

Cela pose des soucis de lock de la table gn_module (plus des potientels problèmes de maintenance de la fonction) qui empechait la réalisation des migations suivantes.

Pour résoudre ce soucis, nous avons finalement utilisé une commande qui permet la migration des permissions existantes dans les instances.

[camillemonchicourt]

@CodiumAI-Agent /review

[CodiumAI-Agent]

PR Analysis

(review updated until commit 8f7d439)

• 🎯 Main theme: Refactoring permission management in the monitoring module
• 📝 PR summary: This PR addresses issues with permission management during alembic migration. It replaces a function with a command to migrate existing permissions in instances, which resolves table lock issues and potential maintenance problems. The PR also includes code to clean existing permissions and update associated module objects.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 4, because the PR involves changes in the permission management system which requires a good understanding of the existing system and the proposed changes. The changes are spread across multiple files and involve SQL queries.
• 🔒 Security concerns: Yes, because the PR includes raw SQL queries which could potentially be vulnerable to SQL injection attacks if not properly sanitized.

PR Feedback

💡 General suggestions: The PR addresses a critical issue in the permission management system and the approach seems to be sound. However, it would be beneficial to add some tests to ensure that the new permission management system works as expected and does not introduce new issues.

---

✨ Usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: [pr_reviewer] # /review # extra_instructions=""" In the code feedback section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

How to enable\disable automation When you first install PR-Agent app, the default mode for the review tool is: pr_commands = ["/review", ...] meaning the review tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations

About the 'Code feedback' section The review tool provides several type of feedbacks, one of them is code suggestions. If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results. Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

Auto-labels The review tool can auto-generate two specific types of labels for a PR: a possible security issue label, that detects possible security issues (enable_review_labels_security flag) a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

Extra sub-tools The review tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: require_score_review, require_soc2_review, enable_review_labels_effort, and more.

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

[CodiumAI-Agent]

Persistent review updated to latest commit 8f7d439

[camillemonchicourt]

@CodiumAI-Agent /improve

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccd3cc8) 71.63% compared to head (a0ab27f) 71.67%.
Report is 1 commits behind head on dev-suivi-eolien.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           dev-suivi-eolien     #291      +/-   ##
====================================================
+ Coverage             71.63%   71.67%   +0.03%     
====================================================
  Files                    31       31              
  Lines                  2193     2196       +3     
====================================================
+ Hits                   1571     1574       +3     
  Misses                  622      622              

Flag	Coverage Δ
pytest	71.67% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.