fix: filter ,sort and page on datatable #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing changes to check according to event on table(sort, filter, page) Refact code for ngOnChanges Reviewed-by: andriac
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-suivi-eolien #310 +/- ##
=================================================
Coverage 75.20% 75.20%
=================================================
Files 30 30
Lines 2182 2182
=================================================
Hits 1641 1641
Misses 541 541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Reviewed-by: andriacap
|
LGTM |
amandine-sahl
pushed a commit
that referenced
this pull request
Jul 29, 2024
* fix: filter ,sort and page on datatable Missing changes to check according to event on table(sort, filter, page) Refact code for ngOnChanges Reviewed-by: andriac * style(front): apply prettier Reviewed-by: andriacap
amandine-sahl
added a commit
that referenced
this pull request
Oct 4, 2024
Remove export as csv test Fix/migrations (#285) * Move create cor_type_site bib_type_site cor_module_type to geonature * Remove id_nomenclature_type_site and migrate model to GeoNature * Move t_observations to GeoNature * Rename cor_type_site to cor_site_type * Bump GeoNature db downgrade does not work with data (#280) Fix test export route (#293) fix: organism_actors attributes fix: clean python files imports + BLACK 24 (#290) * fix: remove relative imports and unused libs * fix: remove unused modules * Add import fixture monitoring_users * Reorder imports * Black --------- Co-authored-by: Mathieu ROUDAUT <[email protected]> Co-authored-by: amandine-sahl <[email protected]> fix: use table models migrated in geonature core BibTypesSites (#292) * fix: use table models migrated in geonature core * fix: imports in tests files * Import TNomenclature from pypnnomenclature --------- Co-authored-by: Mathieu ROUDAUT <[email protected]> Co-authored-by: amandine-sahl <[email protected]> Fix/clean transfert permissions ALL TO MONTORING_XXX (#291) * Script sql de migration des permissions * Changelog Fix : sqlalchemy query Fix/detail site url - cf #298 (#299) * Correction url lien vers détail site * Harmonisation popup carto Fix/synchro on synthese (#288) * remove silented errors when insert in synthese * add migration for trigger delete in synthese --------- Co-authored-by: amandine-sahl <[email protected]> Feat/multiple geom type (#296) * allow multiple geom type * Sites avec plusieurs type de géométrie par défaut --------- Co-authored-by: amandine-sahl <[email protected]> Correction affichage propriétés spécifiques - cf #303 (#304) Fix : migration modification for permissions (#305) * Fix : migration modification for permissions Ajout interaction carte liste (#300) Fix downgrade declare available types sites feat: add unit tests for generic monitoring routes and utils (#295) * feat: add test for config route * feat: add data_utils tests * fix: response code for data utils route * fix: rename test to match source file * fix: remove useless file * fix: remove legacy code * feat: add tests for utils and error Harmonisation des processus d'exécution de sql (#308) * Harmonisation des processus d'exécution de sql * Add test forbidden sql instructions fix: filter ,sort and page on datatable (#310) * fix: filter ,sort and page on datatable Missing changes to check according to event on table(sort, filter, page) Refact code for ngOnChanges Reviewed-by: andriac * style(front): apply prettier Reviewed-by: andriacap
amandine-sahl
added a commit
that referenced
this pull request
Oct 4, 2024
feat: manage geom through protocol - Fix bug changeActiveTab - Add displaying conditional site group geometry through protocol Reviewed-by: andriacap fix: create site group without geom Reviewed-by: andriacap hotfix: remove import AppConfig Error when using docker build Reviewed-by: andriacap Resolve conflicts Use load_default for marshmallow schema - cf #268 add id_digititer to generic observation.json - cf #274 fix migrations downgrade - cf #269 create site with type without custom properties - cf #266 Correction frontend [frontend] Style margin and map height - cf #270 fix site not visible in visit (#272) fix error on site create from module (#275) fix site property not displayed (#277) lint prettier 3.1.0 (#278) Remove laizy joined Correction yml Correction fixture sites Add asset type de site (#282) * Add asset type de site Lint prettier (#281) * Lint prettier 3.1.0 add dev-suivi-eolien in pytest.yml [SqlAlchemy 1.4] compat sqlalchemy 1.4 Corrections + Ajout de tests Remove export as csv test Fix/migrations (#285) * Move create cor_type_site bib_type_site cor_module_type to geonature * Remove id_nomenclature_type_site and migrate model to GeoNature * Move t_observations to GeoNature * Rename cor_type_site to cor_site_type * Bump GeoNature db downgrade does not work with data (#280) Fix test export route (#293) fix: organism_actors attributes fix: clean python files imports + BLACK 24 (#290) * fix: remove relative imports and unused libs * fix: remove unused modules * Add import fixture monitoring_users * Reorder imports * Black --------- Co-authored-by: Mathieu ROUDAUT <[email protected]> Co-authored-by: amandine-sahl <[email protected]> fix: use table models migrated in geonature core BibTypesSites (#292) * fix: use table models migrated in geonature core * fix: imports in tests files * Import TNomenclature from pypnnomenclature --------- Co-authored-by: Mathieu ROUDAUT <[email protected]> Co-authored-by: amandine-sahl <[email protected]> Fix/clean transfert permissions ALL TO MONTORING_XXX (#291) * Script sql de migration des permissions * Changelog Fix : sqlalchemy query Fix/detail site url - cf #298 (#299) * Correction url lien vers détail site * Harmonisation popup carto Fix/synchro on synthese (#288) * remove silented errors when insert in synthese * add migration for trigger delete in synthese --------- Co-authored-by: amandine-sahl <[email protected]> Feat/multiple geom type (#296) * allow multiple geom type * Sites avec plusieurs type de géométrie par défaut --------- Co-authored-by: amandine-sahl <[email protected]> Correction affichage propriétés spécifiques - cf #303 (#304) Fix : migration modification for permissions (#305) * Fix : migration modification for permissions Ajout interaction carte liste (#300) Fix downgrade declare available types sites feat: add unit tests for generic monitoring routes and utils (#295) * feat: add test for config route * feat: add data_utils tests * fix: response code for data utils route * fix: rename test to match source file * fix: remove useless file * fix: remove legacy code * feat: add tests for utils and error Harmonisation des processus d'exécution de sql (#308) * Harmonisation des processus d'exécution de sql * Add test forbidden sql instructions fix: filter ,sort and page on datatable (#310) * fix: filter ,sort and page on datatable Missing changes to check according to event on table(sort, filter, page) Refact code for ngOnChanges Reviewed-by: andriac * style(front): apply prettier Reviewed-by: andriacap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing changes to check according to event on table(sort, filter, page) Refact code for ngOnChanges
Issue: #302
Reviewed-by: andriac