Upgrade decidim to 0.28

.eslintrc.json

@@ -1,240 +1,3 @@
 {
-    "env": {
-        "browser": true,
-        "es2021": true
-    },
-    "extends": [
-        "eslint:recommended",
-        "prettier"
-    ],
-    "parserOptions": {
-        "ecmaVersion": 12,
-        "sourceType": "module"
-    },
-    "globals": {
-        "require": false,
-        "$": false,
-        "jQuery": false,
-        "Foundation": false,
-        "DirectVerificationsConfig": false,
-        "Rails": false
-    },
-  "rules": {
-    "accessor-pairs": "error",
-    "array-bracket-spacing": "error",
-    "array-callback-return": "error",
-    "arrow-body-style": "off",
-    "arrow-parens": [
-      "error",
-      "always"
-    ],
-    "arrow-spacing": [
-      "error",
-      {
-        "after": true,
-        "before": true
-      }
-    ],
-    "block-scoped-var": "error",
-    "block-spacing": "off",
-    "callback-return": "error",
-    "class-methods-use-this": "off",
-    "comma-dangle": ["error", "never"],
-    "comma-spacing": [
-      "error",
-      {
-        "after": true,
-        "before": false
-      }
-    ],
-    "comma-style": [
-      "error",
-      "last"
-    ],
-    "complexity": "error",
-    "computed-property-spacing": [
-      "error",
-      "never"
-    ],
-    "consistent-this": "error",
-    "curly": "error",
-    "default-case": "error",
-    "dot-location": "error",
-    "dot-notation": "error",
-    "eol-last": "error",
-    "func-call-spacing": "error",
-    "func-name-matching": "error",
-    "func-names": [
-      "error",
-      "never"
-    ],
-    "generator-star-spacing": "error",
-    "global-require": "error",
-    "handle-callback-err": "error",
-    "id-blacklist": "error",
-    "id-match": "error",
-    "indent": ["error", 2, { "VariableDeclarator": 2 }],
-    "jsx-quotes": "error",
-    "key-spacing": "error",
-    "keyword-spacing": [
-      "error",
-      {
-        "after": true,
-        "before": true
-      }
-    ],
-    "linebreak-style": [
-      "error",
-      "unix"
-    ],
-    "lines-around-comment": "error",
-    "lines-around-directive": "error",
-    "max-len": "off",
-    "max-lines": "error",
-    "max-nested-callbacks": "error",
-    "max-params": "error",
-    "max-statements": "off",
-    "max-statements-per-line": "error",
-    "multiline-ternary": "error",
-    "new-cap": "error",
-    "new-parens": "error",
-    "newline-after-var": "off",
-    "newline-before-return": "off",
-    "newline-per-chained-call": "off",
-    "no-alert": "error",
-    "no-array-constructor": "error",
-    "no-bitwise": "error",
-    "no-caller": "error",
-    "no-catch-shadow": "error",
-    "no-confusing-arrow": "error",
-    "no-continue": "error",
-    "no-div-regex": "error",
-    "no-duplicate-imports": "error",
-    "no-else-return": "error",
-    "no-eq-null": "error",
-    "no-eval": "error",
-    "no-extend-native": "error",
-    "no-extra-bind": "error",
-    "no-extra-label": "error",
-    "no-extra-parens": "off",
-    "no-floating-decimal": "error",
-    "no-implicit-coercion": "error",
-    "no-implicit-globals": "error",
-    "no-implied-eval": "error",
-    "no-iterator": "error",
-    "no-label-var": "error",
-    "no-labels": "error",
-    "no-lone-blocks": "error",
-    "no-lonely-if": "error",
-    "no-magic-numbers": "off",
-    "no-mixed-requires": "error",
-    "no-multi-spaces": "off",
-    "no-multi-str": "error",
-    "no-multiple-empty-lines": "error",
-    "no-native-reassign": "error",
-    "no-negated-condition": "error",
-    "no-negated-in-lhs": "error",
-    "no-nested-ternary": "error",
-    "no-new": "error",
-    "no-new-func": "error",
-    "no-new-object": "error",
-    "no-new-require": "error",
-    "no-new-wrappers": "error",
-    "no-octal-escape": "error",
-    "no-path-concat": "error",
-    "no-plusplus": "error",
-    "no-process-env": "error",
-    "no-process-exit": "error",
-    "no-proto": "error",
-    "no-prototype-builtins": "error",
-    "no-restricted-globals": "error",
-    "no-restricted-imports": "error",
-    "no-restricted-modules": "error",
-    "no-restricted-properties": "error",
-    "no-restricted-syntax": "error",
-    "no-return-assign": "error",
-    "no-script-url": "error",
-    "no-self-compare": "error",
-    "no-sequences": "error",
-    "no-shadow": "error",
-    "no-shadow-restricted-names": "error",
-    "no-spaced-func": "error",
-    "no-sync": "error",
-    "no-tabs": "error",
-    "no-template-curly-in-string": "error",
-    "no-throw-literal": "error",
-    "no-trailing-spaces": "off",
-    "no-undef-init": "error",
-    "no-undefined": "error",
-    "no-underscore-dangle": "off",
-    "no-unmodified-loop-condition": "error",
-    "no-unneeded-ternary": "error",
-    "no-unused-expressions": "error",
-    "no-use-before-define": "error",
-    "no-useless-call": "error",
-    "no-useless-computed-key": "error",
-    "no-useless-concat": "error",
-    "no-useless-constructor": "error",
-    "no-useless-escape": "error",
-    "no-useless-rename": "error",
-    "no-var": "error",
-    "no-void": "error",
-    "no-warning-comments": "error",
-    "no-whitespace-before-property": "error",
-    "no-with": "error",
-    "object-curly-newline": "off",
-    "object-curly-spacing": "off",
-    "object-property-newline": [
-      "error",
-      {
-        "allowMultiplePropertiesPerLine": true
-      }
-    ],
-    "object-shorthand": "off",
-    "one-var": "off",
-    "one-var-declaration-per-line": "error",
-    "operator-assignment": "error",
-    "operator-linebreak": "error",
-    "padded-blocks": "off",
-    "prefer-arrow-callback": "off",
-    "prefer-const": "off",
-    "prefer-numeric-literals": "error",
-    "prefer-rest-params": "error",
-    "prefer-spread": "error",
-    "prefer-template": "error",
-    "quote-props": "off",
-    "quotes": ["error", "double", { "avoidEscape": true }],
-    "require-jsdoc": "error",
-    "rest-spread-spacing": "error",
-    "semi": "off",
-    "semi-spacing": "error",
-    "sort-imports": "off",
-    "sort-keys": "off",
-    "space-before-blocks": "error",
-    "space-before-function-paren": "off",
-    "space-in-parens": [
-      "error",
-      "never"
-    ],
-    "space-infix-ops": "error",
-    "space-unary-ops": "error",
-    "spaced-comment": [
-      "error",
-      "always"
-    ],
-    "strict": "error",
-    "symbol-description": "error",
-    "template-curly-spacing": "error",
-    "unicode-bom": [
-      "error",
-      "never"
-    ],
-    "vars-on-top": "error",
-    "wrap-iife": "error",
-    "wrap-regex": "error",
-    "yield-star-spacing": "error",
-    "yoda": "error",
-    "import/no-named-as-default": "off",
-    "import/no-extraneous-dependencies": "off"
-  }
+  "extends": "@decidim"
 }

.github/workflows/lint.yml

@@ -0,0 +1,63 @@
+name: Lint
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+env:
+  RUBY_VERSION: 3.1.1
+  NODE_VERSION: 18.17.1
+
+jobs:
+  lint:
+    runs-on: ubuntu-22.04
+    services:
+      postgres:
+        image: postgres:11
+        ports: ["5432:5432"]
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        env:
+          POSTGRES_PASSWORD: postgres
+    env:
+      DATABASE_USERNAME: postgres
+      DATABASE_PASSWORD: postgres
+      DATABASE_HOST: localhost
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 1
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ env.RUBY_VERSION }}
+          bundler-cache: true
+
+      - uses: actions/setup-node@master
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
+      - run: npm ci
+        name: Install JS deps
+
+      - run: bundle exec rubocop -P
+        name: Lint Ruby files
+
+      - run: bundle exec erblint app/views/**/*.erb
+        name: Lint ERB files
+
+      - run: bundle exec mdl *.md
+        name: Lint Markdown files
+
+      - run: npm run lint
+        name: Lint JS files
+
+      - run: npm run stylelint
+        name: Lint SCSS files
+

.github/workflows/test.yml

@@ -7,12 +7,12 @@ on:
   pull_request:
 
 env:
-  RUBY_VERSION: 3.0.2
-  NODE_VERSION: 16.9.1
+  RUBY_VERSION: 3.1.1
+  NODE_VERSION: 18.17.1
 
 jobs:
   test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     services:
       postgres:
         image: postgres:11
@@ -28,6 +28,7 @@ jobs:
       DATABASE_USERNAME: postgres
       DATABASE_PASSWORD: postgres
       DATABASE_HOST: localhost
+      COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
 
     steps:
       - uses: actions/checkout@v2
@@ -39,20 +40,22 @@ jobs:
           ruby-version: ${{ env.RUBY_VERSION }}
           bundler-cache: true
 
+      - uses: actions/setup-node@master
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
       - run: npm ci
         name: Install JS deps
 
-      - run: bundle exec rubocop -P
-        name: Lint Ruby files
-
-      - run: bundle exec erblint app/{cells,views}/**/*.erb
-        name: Lint ERB files
-
-      - run: npm run lint
-        name: Lint JS files
-
       - name: Setup Database
         run: bundle exec rake test_app
 
       - name: Run RSpec
-        run: SIMPLECOV=1 CODECOV=1 bundle exec rake
+        run: CI=1 bundle exec rspec
+
+      - uses: actions/upload-artifact@v3
+        if: always()
+        with:
+          name: screenshots
+          path: ./spec/decidim_dummy_app/tmp/screenshots
+          if-no-files-found: ignore

.gitignore

@@ -23,7 +23,6 @@ development_app
 .byebug_history
 node_modules/
 npm_debug.log
-.ruby-version
 tags
 *.gem
 .rubocop-*

.mdl_style.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+all
+
+exclude_rule "first-line-h1"
+
+exclude_rule "line-length"
+
+exclude_rule "no-bare-urls"
+
+exclude_rule "no-inline-html"
+
+rule "no-trailing-punctuation", punctuation: ".,;:!"

.mdlrc

@@ -0,0 +1 @@
+style ".mdl_style.rb"

.node-version

@@ -0,0 +1 @@
+18.17.1