Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade decidim to 0.28 #58

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Upgrade decidim to 0.28 #58

wants to merge 26 commits into from

Conversation

fblupi
Copy link
Member

@fblupi fblupi commented Sep 25, 2024

Fixes #57

Copy link

gitguardian bot commented Sep 25, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9774313 Triggered Generic Password 376f301 .github/workflows/test.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.56%. Comparing base (a1581ec) to head (52bafec).

❗ There is a different number of reports uploaded between BASE (a1581ec) and HEAD (52bafec). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a1581ec) HEAD (52bafec)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   98.63%   93.56%   -5.07%     
==========================================
  Files          39       39              
  Lines         732      746      +14     
==========================================
- Hits          722      698      -24     
- Misses         10       48      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HHassig HHassig force-pushed the deps/decidim-0.28 branch from 52bafec to b0cfdf8 Compare January 7, 2025 11:43
@HHassig
Copy link

HHassig commented Jan 7, 2025

I can't get this last test to pass:

ArgumentError:
       When assigning attributes, you must pass a hash as an argument, NilClass passed.
  1. When I print the params and handler, it isn't nil, so I'm unsure what the issue is...
  2. Regarding the lint error, the tests won't pass with .now and lint won't pass without it...

@fblupi
Copy link
Member Author

fblupi commented Jan 8, 2025

@HHassig regarding the lint error, disable the failing Rubocop rule for that line.

…in/user_authorizations_controller_spec.rb

Co-authored-by: Fran Bolívar <[email protected]>
@HHassig HHassig force-pushed the deps/decidim-0.28 branch from d51b1c6 to eff9898 Compare January 8, 2025 08:09
@fblupi fblupi requested a review from HHassig January 8, 2025 09:00
@fblupi fblupi marked this pull request as ready for review January 8, 2025 09:00
HHassig
HHassig previously approved these changes Jan 8, 2025
Copy link

@HHassig HHassig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for showing me the ropes.

@fblupi fblupi requested a review from HHassig January 9, 2025 15:53
Copy link

@HHassig HHassig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants