-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade decidim to 0.28 #58
base: main
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9774313 | Triggered | Generic Password | 376f301 | .github/workflows/test.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
22b18de
to
b0cfdf8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 98.63% 93.56% -5.07%
==========================================
Files 39 39
Lines 732 746 +14
==========================================
- Hits 722 698 -24
- Misses 10 48 +38 ☔ View full report in Codecov by Sentry. |
52bafec
to
b0cfdf8
Compare
I can't get this last test to pass:
|
@HHassig regarding the lint error, disable the failing Rubocop rule for that line. |
...llers/decidim/direct_verifications/verification/admin/user_authorizations_controller_spec.rb
Outdated
Show resolved
Hide resolved
…in/user_authorizations_controller_spec.rb Co-authored-by: Fran Bolívar <[email protected]>
d51b1c6
to
eff9898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks for showing me the ropes.
…ications-direct_verifications into deps/decidim-0.28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bravo!
Fixes #57