-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add problem_file launch argument to problem_expert_launch.py #274
Conversation
…ile. Also changed plansys2_bringup_launch_distributed.py to be able to handle the new argument. Now PlanSys2 can be started with domain.pddl and problem.pddl and solve the plane right away. NOTE: this will be a (small) breaking change.
default problem file is empty now
done |
@robodrome CI is failing here |
double quotes to single
|
added newline at end of file
Still failing @robodrome |
remove ending whitespace, flake8 seems to be having issues with this
try to fix some flake8 errors with whitespaces
Yes i see. I am trying to figure out what is going on. I don't have much experience with CI in github, but I think flask8 is giving errors due to white space formatting errors. I look at the failure messages and tried to fix it. I will keep trying. |
Do the tests fail for you locally in your machine? |
I haven't tried. I just copied the contents. The code runs fine however. There is one failure left, i removed a trailing whitespace so we'll see if that fixed it. i will run the tests locally next time. BTW, I see there has been some discussion about pre-commit: #248 (comment) |
deleted trailing whitespace
i am going to try this again later with a separate branch |
problem_expert_launch.py
namedproblem_file
.plansys2_bringup_launch_distributed.py
to be able to handle the new argument.domain_expert_cmd
inproblem_expert_launch.py
, possibly the result of a copy-paste action.Now PlanSys2 can be started with domain.pddl and problem.pddl and solve the plane right away. You still need to start (or run) the plan.
NOTE: this will be a (small) breaking change.