Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add problem_file launch argument to problem_expert_launch.py #274

Closed
wants to merge 7 commits into from
Closed

Add problem_file launch argument to problem_expert_launch.py #274

wants to merge 7 commits into from

Conversation

robodrome
Copy link
Contributor

  • Add extra launch argument to problem_expert_launch.py named problem_file.
  • Changed plansys2_bringup_launch_distributed.py to be able to handle the new argument.
  • Renamed domain_expert_cmd in problem_expert_launch.py, possibly the result of a copy-paste action.

Now PlanSys2 can be started with domain.pddl and problem.pddl and solve the plane right away. You still need to start (or run) the plan.

NOTE: this will be a (small) breaking change.

…ile. Also changed plansys2_bringup_launch_distributed.py to be able to handle the new argument. Now PlanSys2 can be started with domain.pddl and problem.pddl and solve the plane right away. NOTE: this will be a (small) breaking change.
default problem file is empty now
@robodrome
Copy link
Contributor Author

done

@fmrico
Copy link
Contributor

fmrico commented Sep 22, 2023

@robodrome CI is failing here

double quotes to single
@robodrome
Copy link
Contributor Author

robodrome commented Sep 22, 2023

  • i used double quotes. changed it to single
  • and added newline to launch file

@fmrico
Copy link
Contributor

fmrico commented Sep 23, 2023

Still failing @robodrome

remove ending whitespace, flake8 seems to be having issues with this
try to fix some flake8 errors with whitespaces
@robodrome
Copy link
Contributor Author

Still failing @robodrome

Yes i see. I am trying to figure out what is going on. I don't have much experience with CI in github, but I think flask8 is giving errors due to white space formatting errors. I look at the failure messages and tried to fix it. I will keep trying.

@fmrico
Copy link
Contributor

fmrico commented Sep 23, 2023

Do the tests fail for you locally in your machine?

@robodrome
Copy link
Contributor Author

robodrome commented Sep 23, 2023

Do the tests fail for you locally in your machine?

I haven't tried. I just copied the contents. The code runs fine however. There is one failure left, i removed a trailing whitespace so we'll see if that fixed it. i will run the tests locally next time.

BTW, I see there has been some discussion about pre-commit: #248 (comment)

@robodrome robodrome requested a review from fmrico September 23, 2023 09:12
@robodrome
Copy link
Contributor Author

i am going to try this again later with a separate branch

@robodrome robodrome closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants