Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get focused button unresponsive on firefox quantum #21

Closed
SB-FM opened this issue Jul 6, 2018 · 3 comments
Closed

Get focused button unresponsive on firefox quantum #21

SB-FM opened this issue Jul 6, 2018 · 3 comments
Assignees
@adilanchian
Labels
bug Something isn't working release-1.0.1

Comments

@SB-FM
Copy link

SB-FM commented Jul 6, 2018 •
edited
Loading

The Get Focused button on focusblock.stream appears to be unresponsive on Firefox Quantum. Clicking it does not redirect to dashboard. Also doesn't throw an error in the console.

Disabled all addons and still experience that behavior.

Firefox Quantum Version 61.0.1 (64bit)
@SB-FM SB-FM changed the title Get focusblock button unresponsive on firefox quantum Get focused button unresponsive on firefox quantum Jul 6, 2018
@lukeberry99
Copy link

This is because the <Link> is inside a button, and the buttons click event is taking precedence over the <Link>

@adilanchian
Copy link
Contributor

^^ Yup @lukeberry99 thats exactly right! stupid mistake on my end haha. Would you or @SB-FM want to make a quick fix for this? Would love to get this fixes!

@adilanchian adilanchian added bug Something isn't working release-1.0.1 labels Jul 7, 2018
@adilanchian adilanchian self-assigned this Jul 14, 2018
adilanchian added a commit that referenced this issue Jul 14, 2018
@adilanchian
Fixing button reponse issue && removing visted link, text color #21
b02483b
@adilanchian
Copy link
Contributor

This has been fixed and committed directly to release-1.0.1

@adilanchian adilanchian mentioned this issue Dec 15, 2018
Merged
adilanchian added a commit that referenced this issue Dec 15, 2018
@adilanchian
Release 1.0.1 (#31)
e42a2f6 
* Bug fixes #20 to release 1.0.1 branch (#24)

* BUG FIX #20 - added a min number value to stop users inserting negative numbers.

* BUG FIX #20 - changed min to 1 to avoid a 0 custom input

* BUG FIX #20 - added max limit to 1 year for custom input.

* BUG FIX #20 - added a field length check to the title input to avoid empty inputs.

* BUG FIX #20 - added attribute type button to both the delete and cancel button to ensure when user presses enter it submits the form.

* BUG FIX #20 - quick clean up

* BUG FIX #20 - removed the html min and max attributes and incorporated it into the validator function for consistency purposes.

* Fixing button reponse issue && removing visted link, text color #21

* Changed lets to consts, and some restructuring of variables and state. (#30)

* Changed lets to consts, and some restructuring of variables and state.

* resolve conflict in BlockForm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adilanchian adilanchian

Labels
bug Something isn't working release-1.0.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukeberry99 @SB-FM @adilanchian