Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs #20

Closed
xmxstudio opened this issue Jul 5, 2018 · 5 comments
Closed

Bugs #20

xmxstudio opened this issue Jul 5, 2018 · 5 comments
Labels
bug Something isn't working release-1.0.1

Comments

@xmxstudio
Copy link

xmxstudio commented Jul 5, 2018 •
edited by adilanchian
Loading

  • User can enter blank title
  • User can enter custom unchecked time. (e.g., -10, 0, 111111111111111111111111)
  • When editing focus block title. pressing enter defaults to delete prompt. bad UX
  • When time is too great, countdown timer does not work when clicking get focused

https://focusblock.stream/dashboard/ByiZCdsfm
@xmxstudio
Copy link
Author

https://focusblock.stream/dashboard/****enterAnything
https://focusblock.stream/404pagehandlerneeded

@adilanchian adilanchian added bug Something isn't working release-1.0.1 labels Jul 7, 2018
@adilanchian
Copy link
Contributor

@xmxstudio I updated your bug with some formatting :)

@frubesss Thanks so much for getting these commits in! Would you be able to check off the fixes you have made so far? I am excited to see your PR!

@frubesss
Copy link

frubesss commented Jul 8, 2018 •
edited
Loading

@adilanchian Hi, just working through all these bugs while I have a bit of downtime.

Will have explanations to my reasoning behind these changes with the pull request.

I can't tick the tasks off in the original post as I don't have edit permissions.

Thanks

@adilanchian
Copy link
Contributor

Hey @frubesss,

Thanks for the heads up and no worries at all! Glad to see you are adding some dope fixes. No worries about the list, I will go ahead and change that.

adilanchian pushed a commit that referenced this issue Jul 13, 2018
@frubesss @adilanchian
Bug fixes #20 to release 1.0.1 branch (#24)
b0a16bd 
* BUG FIX #20 - added a min number value to stop users inserting negative numbers.

* BUG FIX #20 - changed min to 1 to avoid a 0 custom input

* BUG FIX #20 - added max limit to 1 year for custom input.

* BUG FIX #20 - added a field length check to the title input to avoid empty inputs.

* BUG FIX #20 - added attribute type button to both the delete and cancel button to ensure when user presses enter it submits the form.

* BUG FIX #20 - quick clean up

* BUG FIX #20 - removed the html min and max attributes and incorporated it into the validator function for consistency purposes.
@adilanchian
Copy link
Contributor

MERGED! Thanks for all the work :)

@adilanchian adilanchian mentioned this issue Dec 15, 2018
Merged
adilanchian added a commit that referenced this issue Dec 15, 2018
@adilanchian
Release 1.0.1 (#31)
e42a2f6 
* Bug fixes #20 to release 1.0.1 branch (#24)

* BUG FIX #20 - added a min number value to stop users inserting negative numbers.

* BUG FIX #20 - changed min to 1 to avoid a 0 custom input

* BUG FIX #20 - added max limit to 1 year for custom input.

* BUG FIX #20 - added a field length check to the title input to avoid empty inputs.

* BUG FIX #20 - added attribute type button to both the delete and cancel button to ensure when user presses enter it submits the form.

* BUG FIX #20 - quick clean up

* BUG FIX #20 - removed the html min and max attributes and incorporated it into the validator function for consistency purposes.

* Fixing button reponse issue && removing visted link, text color #21

* Changed lets to consts, and some restructuring of variables and state. (#30)

* Changed lets to consts, and some restructuring of variables and state.

* resolve conflict in BlockForm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release-1.0.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frubesss @xmxstudio @adilanchian