Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE: OIT issue fix for MaterialX #2614

Merged

Conversation

slingthor
Copy link
Contributor

Description of Change(s)

  • Explicit returns for discards for Metal shading language version less than 2_4
  • Parts of our earlier MaterialX PR which couldn't be included in last release are explicitly put out in PR, for discussion and hopeful landing in next release

Fixes Issue(s)

  • OIT buffer invalidly written into when the intention was to stop shader execution due to discard
  • When one such asset is included, especially with MaterialX, the whole frame buffer becomes noisy and glitchy
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8614

@dgovil
Copy link
Collaborator

dgovil commented Oct 30, 2023

Just leaving a note here for others who hit it, that this PR fixes a lot of the corruption issues that people will see using MaterialX in usdview, where you'll see tiles of images just completely disappearing and flickering inter-frame.

Without this PR, MaterialX on usdview becomes very unusable on a Mac.

@slingthor slingthor changed the title OIT issue fix for MaterialX APPLE: OIT issue fix for MaterialX Nov 6, 2023
@ashwinbhat
Copy link
Contributor

Thanks @slingthor it works well!!

@pixar-oss pixar-oss merged commit 59848c4 into PixarAnimationStudios:dev Dec 11, 2023
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants