Cylinders and Capsules with two radii #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for registering an adaptor which handles all schemas in a family *and* the schemas which derive from a versioned schema. i.e., an adapter can handle all of: class Cylinder "Cylinder" ( inherits = </Gprim> ... class MyCustomCylinder "MyCustomCylinder" ( inherits = </Cylinder> ... class Cylinder_1 "Cylinder_1" ( inherits = </Gprim> ... class MyCustomCylinder2 "MyCustomCylinder2" ( inherits = </Cylinder_1> ...
Not enough overlap between the two builders.
Same treatment as capsules.
|
Filed as internal issue #USD-8594 |
eoineoineoin
changed the title
pixar-oss
pushed a commit
that referenced
this pull request
Sep 19, 2023
pluginInfo.json This allows one adapter to be used to render multiple different schema versions. This will be used in the subsequent change to use CylinderAdapter and CapsuleAdapter respectively for UsdGeomCylinder_1 and UsdGeomCapsule_1 renders. Changes split from #2596 (Internal change: 2294998)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Adds a new schema version of Cylinder and Capsule, which accept different radii for each end. (Some discussion at https://groups.google.com/g/usd-interest/c/zC7wYK7wN-Y/m/PZoEiEkXAgAJ) This allows construction of tapered capsules and conic sections.
Uses schema versioning to add a Cylinder_1 as well as a Capsule_1; as such, most of the code in this PR is auto-generated. However, in addition to adding these types, adds some additional fixes:
Along the way, I split the HdCapsuleSchema and HdCylinderSchema into two classes (HdCapsule_1Schema and HdCylinder_1Schema) - though the two schema versions are very similar, it felt like there was limited overlap between the "version 0" and "version 1" to enable effective code re-use, particularly in the
Builderinterface. Am aware the schema versioning is quite new though, so expect some teething issues like this - open to ideas on how this could be organized better.Fixes Issue(s)
Am seeing some failures on my machine; comparing reference images, they appear unrelated to these changes; some line-drawing aliasing appears different as well as some textures have failed to load.