Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bailp/emsusd 239/corrupted file read crash #2552

Commits on Jun 28, 2023

  1. Fix crash when reading corrupted USD files.

    - Throw an exception when detecting an out-of-bound read instead of returning random data.
    - Catch exception in the parallel read dispatcher, otherwise some destructors that run afterward cause double-exception termination or read invalid memory.
    pierrebai-adsk committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    49b500e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Improve exception handling

    - CrateFile helpers re-throw the exceptions they caught.
    - CreateData remembers that exceptions were thrown during I/O and returns an error.
    - Cratedata cannot throw an exception because it is invoked in parallel code that crash when exceptions are thrown. Error return are used instead.
    - With this, the error propagates to the caller that tried to load the layer or stage.
    pierrebai-adsk committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    5f56cf2 View commit details
    Browse the repository at this point in the history