Bailp/emsusd 239/corrupted file read crash #2552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Throw an exception when detecting an out-of-bound read instead of returning random data. - Catch exception in the parallel read dispatcher, otherwise some destructors that run afterward cause double-exception termination or read invalid memory.
- CrateFile helpers re-throw the exceptions they caught. - CreateData remembers that exceptions were thrown during I/O and returns an error. - Cratedata cannot throw an exception because it is invoked in parallel code that crash when exceptions are thrown. Error return are used instead. - With this, the error propagates to the caller that tried to load the layer or stage.
seando-adsk
commented
Jul 25, 2023
| @@ -595,8 +596,7 @@ struct _MmapStream { | |||
| "Read out-of-bounds: %zd bytes at offset %td in " | |||
| "a mapping of length %zd", | |||
| nBytes, offset, mapLen); | |||
| memset(dest, 0x99, nBytes); | |||
| return; | |||
| throw std::runtime_error("Read out of bounds"); | |||
There was a problem hiding this comment.
This is the actual fix
|
Filed as internal issue #USD-8537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fixes Issue(s)