Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MaterialX v1.38.5 #1965

Closed
wants to merge 1 commit into from

Conversation

pablode
Copy link
Contributor

@pablode pablode commented Jul 27, 2022

Description of Change(s)

This PR makes USD (specifically hdStorm) MaterialX 1.38.5-ready.

The changes between 1.38.4 and 1.38.5 are addressed as following:

  • the new transmission handling option is set to TRANSMISSION_OPACITY for tests to pass as suggested by @JGamache-autodesk (#929)

  • addition of the emission call for said option (#994)

  • changes for code generation from material nodes (#981)

  • lastly, Jonathan inlined the GlslShaderGenerator::TARGET constant in #926, which doesn't need an #ifguard because the value is the same in both 1.38.3 and 1.38.4

  • I have submitted a signed Contributor License Agreement

@sunyab
Copy link
Contributor

sunyab commented Jul 28, 2022

Filed as internal issue #USD-7523

@dgovil
Copy link
Collaborator

dgovil commented Apr 10, 2023

@sunyab were there any updates on this PR or #2324 with regards to USD 23.5?

MaterialX should be bumping up to 1.38.7 soon, and afaik there aren't any API changes since 1.38.5 (.4 was hopefully an anomaly). 1.38.7 has a lot of niceties including MSL support that would be nice to have in a pipeline. Having this PR in would ease a lot of downstream build complexity.

@spiffmon
Copy link
Member

Hi @dgovil . We never got to the out-of-band work to get 1.38.5 installed in our vfx2020 platform. We are currently filling out our vfx2022 platform, and 1.38.6 is already installed there. We are still hoping to be able to switch to that platform before summer, but there may still be snags that come up. Would it be better to try to get 1.38.5 now, or try to be ready for the release of 1.38.7 and add that to our vfx2022 platform asap? I don't think we have resources to do both.

@dgovil
Copy link
Collaborator

dgovil commented Apr 11, 2023

@spiffmon that's good to know. I agree that VFX Platform 2022 is more important.
The reason I pinged this was that we're trying to get MaterialX into Blender against MaterialX 1.38.6, so we were trying to get more info about this particular PR to figure out a plan of action.

@brechtvl
Copy link
Contributor

Maybe this could be merged without the change to build_usd.py? That would add compatibility with newer MaterialX versions without requiring anyone to switch immediately.

Compatibility is all that is needed for Blender and I imagine various other software, where library versions are not dictated by USD.

@pixar-oss pixar-oss closed this in 5dab6e0 Jul 21, 2023
AdamFelt pushed a commit to autodesk-forks/USD that referenced this pull request Apr 16, 2024
USD 22.08 required MaterialX 1.38.4 minimum. At Autodesk we want to align on 1.38.5.
The changes are based on an open Pixar PR PixarAnimationStudios#1965
(cherry picked from commit d9b3c81)
Co-authored-by: Pablo Delgado Krämer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants