Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold control to resize selection when you're in the move-selected tool #138

Merged
merged 4 commits into from
Mar 27, 2020

Conversation

jaburns
Copy link
Contributor

@jaburns jaburns commented Mar 27, 2020

Resizing the actual contents of a selection is something I noticed right away that was missing when compared to Paint.NET. This PR introduces behavior that doesn't mirror Paint.NET's resize handles directly, but it at least provides a way to resize the contents of the current selection without copying your selection in to a temporary file and resizing the whole canvas.

@cameronwhite
Copy link
Member

Thanks for the contribution, this looks good!
Could you also update the tooltip for this tool to mention this feature?

@jaburns
Copy link
Contributor Author

jaburns commented Mar 27, 2020

Sure, will do!

@jaburns
Copy link
Contributor Author

jaburns commented Mar 27, 2020

Done. Let me know if you'd like the wording to be something different. I also enbled right shift and right control to toggle the features mentioned in the tooltip since the tooltip didn't say a specific key.

@cameronwhite
Copy link
Member

Thanks! I think the wording might make it sound as though scaling is part of the right-click mode, whereas it's actually only left-cllick + Ctrl to do scaling?

@jaburns
Copy link
Contributor Author

jaburns commented Mar 27, 2020

It's ctrl + either mouse button click and drag to scale. I agree it sounds like a sub-feature of the right mouse button thing though. How's this: "Left click and drag the selection to move selected content. Hold Ctrl to scale instead of move. Right click and drag the selection to rotate selected content. Hold Shift to rotate in steps."

@cameronwhite
Copy link
Member

Yep, that sounds good!

@jaburns
Copy link
Contributor Author

jaburns commented Mar 27, 2020

Cool! Updated

@cameronwhite cameronwhite merged commit 9606d10 into PintaProject:master Mar 27, 2020
@cameronwhite
Copy link
Member

Looks good, thanks!

@goginaa
Copy link

goginaa commented Apr 24, 2020

I don't think my Pinta has been updated yet, i'm still unable to resize nor has the tooltip changed

@cameronwhite
Copy link
Member

It would likely not have been updated unless you're using the daily builds PPA for Ubuntu, or are building from source

@goginaa
Copy link

goginaa commented Apr 24, 2020

I'm sorry I don't know any of those things, all I use is Pinta on my Apple desktop

@cameronwhite
Copy link
Member

Ok, in that case you won't have the update yet

@Sceat
Copy link

Sceat commented Nov 2, 2020

@jaburns is there a way to scale without losing the ratio ?

@jaburns
Copy link
Contributor Author

jaburns commented Nov 3, 2020

I didn't implement that, no. But it should be easy to add if you want, it would just be some logic to add in the same places that this commit touches: be2a139

cameronwhite added a commit that referenced this pull request Nov 7, 2020
Also cleaned up the key handling a bit since the previous approach didn't handle Shifft and Ctrl being pressed together. The scale mode should also apply for the entire mouse down -> mouse up duration rather than toggling on and off.

#138
@cameronwhite
Copy link
Member

I've added 6b32605 which implements this.

@Zekiah-A
Copy link
Contributor

Are there any plans to add handles in order to do this as well? That would be quite useful for precise scaling, and would make the experience more similar to that of pdn

@cameronwhite
Copy link
Member

Not any immediate plans as the main focus right now is the GTK3 port. But contributions are very welcome!

@Zekiah-A
Copy link
Contributor

Zekiah-A commented Dec 1, 2021

Yeah, i'll work on this if i have any free time to do so, sounds like a fun thing to add,
Also, will the GTK 3 port follow the system GTK theme, since the current version does not seem to by default.

@cameronwhite
Copy link
Member

Yes, the gtk3 version should be better at using the system theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants