-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hold control to resize selection when you're in the move-selected tool #138
Conversation
Thanks for the contribution, this looks good! |
Sure, will do! |
Done. Let me know if you'd like the wording to be something different. I also enbled right shift and right control to toggle the features mentioned in the tooltip since the tooltip didn't say a specific key. |
Thanks! I think the wording might make it sound as though scaling is part of the right-click mode, whereas it's actually only left-cllick + Ctrl to do scaling? |
It's ctrl + either mouse button click and drag to scale. I agree it sounds like a sub-feature of the right mouse button thing though. How's this: "Left click and drag the selection to move selected content. Hold Ctrl to scale instead of move. Right click and drag the selection to rotate selected content. Hold Shift to rotate in steps." |
Yep, that sounds good! |
Cool! Updated |
Looks good, thanks! |
I don't think my Pinta has been updated yet, i'm still unable to resize nor has the tooltip changed |
It would likely not have been updated unless you're using the daily builds PPA for Ubuntu, or are building from source |
I'm sorry I don't know any of those things, all I use is Pinta on my Apple desktop |
Ok, in that case you won't have the update yet |
@jaburns is there a way to scale without losing the ratio ? |
I didn't implement that, no. But it should be easy to add if you want, it would just be some logic to add in the same places that this commit touches: be2a139 |
Also cleaned up the key handling a bit since the previous approach didn't handle Shifft and Ctrl being pressed together. The scale mode should also apply for the entire mouse down -> mouse up duration rather than toggling on and off. #138
I've added 6b32605 which implements this. |
Are there any plans to add handles in order to do this as well? That would be quite useful for precise scaling, and would make the experience more similar to that of pdn |
Not any immediate plans as the main focus right now is the GTK3 port. But contributions are very welcome! |
Yeah, i'll work on this if i have any free time to do so, sounds like a fun thing to add, |
Yes, the gtk3 version should be better at using the system theme |
Resizing the actual contents of a selection is something I noticed right away that was missing when compared to Paint.NET. This PR introduces behavior that doesn't mirror Paint.NET's resize handles directly, but it at least provides a way to resize the contents of the current selection without copying your selection in to a temporary file and resizing the whole canvas.