Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with selection tool handles still being enabled while invisible after deselecting #105

Closed
wants to merge 3 commits into from

Conversation

codecat
Copy link

@codecat codecat commented Jun 10, 2015

This one bothered me, so I decided to make a (quick) fix for it. The second commit is kind of an ugly workaround, but it works, and is the fastest way to get the job done properly.

…o still be active even after the user has deselected by clicking on an empty space.
… that Ctrl+D also resets the handles (kind of an ugly workaround though)
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it ! I like it ! I like it ! I like it ! I like it !

@ghost
Copy link

ghost commented Aug 4, 2019

@cameronwhite please merge tha nk you

@EmilyRosina
Copy link

Pleeeeeeeease just merge it (after rebasing obvs) but this is such a vital thing to not have in an image editor 💢

@Restioson
Copy link

Any reason that this hasn't been merged yet? Seems overdue.

@cameronwhite
Copy link
Member

Apologies for losing track of this.
This change is a hacky workaround, so I would prefer a change that fixes the underlying issue (i.e. why isn't the existing AfterSelectionChange() handler in the select tool being triggered when the selection is cleared?)

@jaburns
Copy link
Contributor

jaburns commented Mar 23, 2020

It's a hacky workaround, but it is very small. Would you consider just applying the hack fix and then opening a separate issue to fix the hack in a more correct manner? This way the problem can be solved in the mean time while any developers that feel like solving it correctly come up with a solution.

The app is virtually unusable for me without being able to resize selections, and it's the only issue I have with Pinta.

@codecat
Copy link
Author

codecat commented Mar 26, 2020

5 years later, and there's activity on this pull request, wow! For what it's worth, I'm not sure how valid this pull request still is, considering stuff seems to have changed quite a bit (judging by the fact that there is now a merge conflict).

I don't use Pinta anymore myself so perhaps a new pull request would be good?

@jaburns
Copy link
Contributor

jaburns commented Mar 27, 2020

Manually applying the changes in this PR was reasonable. All of the code neighboring the diffs still seems to exist in the same form, but applying these changes now doesn't fix the issue anymore. I guess I'm going to have to dig a little deeper.

@jaburns
Copy link
Contributor

jaburns commented Mar 27, 2020

Sorry I thought this PR was for something else. I arrived here from this bug report ( https://bugs.launchpad.net/pinta/+bug/1473430 ) which is about not being able to resize the current selection using the move-selected tool, and I see now that this PR is about fixing lingering handles in the selection tool.

Anyway I've implemented "Hold control to resize when you're in the move-selected tool" on a fork, if anyone else lands here from that bug report and is looking for a way to resize the current selection.

I'll make a separate PR for that in case the Pinta developers are interested in merging that feature.

@topotech
Copy link

Anyway I've implemented "Hold control to resize when you're in the move-selected tool" on a fork, if anyone else lands here from that bug report and is looking for a way to resize the current selection.

In which fork? 😮

@jaburns
Copy link
Contributor

jaburns commented Apr 22, 2020

I implemented it in this PR which has now been merged in to master #138 . So if you build the latest on master you should have that feature :)

cameronwhite added a commit that referenced this pull request Jul 21, 2020
- Move Document.ShowSelection into the DocumentSelection class, so that it doesn't require extra handling to keep it in sync when undo / redo events occur

- More importantly, emit events when the selection visibility changes so that the select tool can update after e.g. a deselect event. Removed a workaround in the MouseUp event that cleared the tool layer explicitly (which didn't work when the Deselect menu item was used).

- Update the selection handles from the active selection when switching back into the select tool.

Related to #1188924, 1429830, 1098137, 1424551, and pull request #105
@cameronwhite
Copy link
Member

This should be fixed by f78d88a so I think this PR can be closed now!

@spitemim
Copy link

Still hasn't been fixed as of August 22. Pinta is the 100% perfect application for me, but this is a dealbreaker.

@cameronwhite
Copy link
Member

Can you provide the steps to reproduce the issue you're still seeing?

@spitemim
Copy link

I'm really sorry. Right after I left the comment, the resizing started working again. My bad.

@keef1212
Copy link

Still not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants