Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor msb build job to make it able to trigger by comment in PR. #380

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Aug 13, 2024

Ref #379

Signed-off-by: wuhuizuo [email protected]

@wuhuizuo
Copy link
Contributor Author

/just msb-pd

@wuhuizuo wuhuizuo marked this pull request as ready for review August 13, 2024 04:11
@wuhuizuo
Copy link
Contributor Author

/just msb-pd

Copy link

ti-chi-bot bot commented Aug 13, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request migrates the linux builder OS from CentOS 7 to RockyLinux 8. The changes include modifying the workflow file to use RockyLinux 8 instead of CentOS 7 and updating the Justfile to reflect the changes.

There are no potential problems identified in the pull request. However, it is important to test the changes thoroughly to ensure that the migration does not cause any issues with the build process.

One suggestion for fixing is to add more specific details in the pull request description, such as the reasoning behind the migration and any specific benefits it provides. Additionally, it may be helpful to include any instructions or steps that need to be taken after the migration is complete.

@wuhuizuo
Copy link
Contributor Author

/just msb-pd

@wuhuizuo wuhuizuo changed the title Migrate linux builder OS from CentOS 7 to RockyLinux 8 ci: refactor msb build job to make it able to trigger by comment in PR. Aug 13, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5236657 into main Aug 13, 2024
1 check passed
@ti-chi-bot ti-chi-bot bot deleted the wuhuizuo/issue379 branch August 13, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant