Migrate linux builder OS from CentOS 7 to RockyLinux 8

Fixes #379 Signed-off-by: wuhuizuo <[email protected]>
PingCAP-QE · Aug 13, 2024 · cfd84ed · cfd84ed
1 parent 4bdc4c6
commit cfd84ed
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 13 deletions.
diff --git a/.github/workflows/pull-cd-builder-images2.yaml b/.github/workflows/pull-cd-builder-images2.yaml
@@ -1,13 +1,17 @@
 name: Build multi stage images
 on:
-  workflow_dispatch:
+  issue_comment:
+    types: [created, edited, deleted]
 
 concurrency:
   group: ${{ github.workflow }}
   cancel-in-progress: false
 
 jobs:
   just-build:
+    # check if the comments come from pull request, exclude those from issue.
+    if: ${{ github.event.issue.pull_request && contains(github.event.comment.body, '/just msb-') }}
+
     name: test building with multi stages
     runs-on: ubuntu-latest
 
@@ -19,6 +23,11 @@ jobs:
       - name: Checkout sources
         uses: actions/checkout@v4
 
+      - name: Checkout Pull Request
+        run: hub pr checkout ${{ github.event.issue.number }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
       # https://github.com/docker/setup-qemu-action
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
@@ -31,7 +40,7 @@ jobs:
         uses: extractions/setup-just@v2
         with:
           github-token: ${{ secrets.MY_GITHUB_TOKEN }}
-          just-version: 1.34.0  # optional semver specification, otherwise latest
+          just-version: 1.34.0 # optional semver specification, otherwise latest
 
       - name: Log in to the Container registry
         uses: docker/login-action@v3
@@ -40,12 +49,30 @@ jobs:
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
-      - { name: Testing for tidb, run: just msb-tidb }
-      - { name: Testing for pd, run: just msb-pd }
-      - { name: Testing for CDC of tiflow, run: just msb-cdc }
-      - { name: Testing for DM of tiflow, run: just msb-dm }
-      - { name: Testing for ng-monitoring, run: just msb-ng-monitoring }
-      - { name: Testing for tidb-dashboard, run: just msb-tidb-dashboard }
-      - { name: Testing for tidb-operator, run: just msb-tidb-operator }
-      # - { name: Testing for tiflash, run: just msb-tiflash } # slow
-      # - { name: Testing for tikv, run: just msb-tikv } # slow
+      - name: Testing for tidb
+        run: just msb-tidb
+        if: contains('msb-tidb', github.event.issue.body)
+      - name: Testing for pd
+        run: just msb-pd
+        if: contains('msb-pd', github.event.issue.body)
+      - name: Testing for CDC of tiflow
+        run: just msb-cdc
+        if: contains('msb-cdc', github.event.issue.body)
+      - name: Testing for DM of tiflow
+        run: just msb-dm
+        if: contains('msb-dm', github.event.issue.body)
+      - name: Testing for TiDB Dashboard
+        run: just msb-tidb-dashboard
+        if: contains('msb-tidb-dashboard', github.event.issue.body)
+      - name: Testing for TiDB Operator
+        run: just msb-tidb-operator
+        if: contains('msb-tidb-operator', github.event.issue.body)
+      - name: Testing for ng-monitoring
+        run: just msb-ng-monitoring
+        if: contains('msb-ng-monitoring', github.event.issue.body)
+      - name: Testing for tiflash # slow
+        run: just msb-tiflash
+        if: contains('msb-tiflash', github.event.issue.body) 
+      - name: Testing for tikv # slow
+        run: just msb-tikv
+        if: contains('msb-tikv', github.event.issue.body)
diff --git a/Justfile b/Justfile
@@ -7,8 +7,8 @@ msb-tiflash: (_clone "tiflash" "https://github.com/pingcap/tiflash" "master")
 msb-dm: (_clone "tiflow" "https://github.com/pingcap/tiflow.git" "master")
     docker build --load -t localhost/dm:local-build -f dockerfiles/cd/builders/tiflow/Dockerfile --target final-dm ../tiflow
 
-msb-ticdc: (_clone "tiflow" "https://github.com/pingcap/tiflow.git" "master")
-    docker build --load -t localhost/ticdc:local-build -f dockerfiles/cd/builders/tiflow/Dockerfile --target final-cdc ../tiflow
+msb-cdc: (_clone "tiflow" "https://github.com/pingcap/tiflow.git" "master")
+    docker build --load -t localhost/cdc:local-build -f dockerfiles/cd/builders/tiflow/Dockerfile --target final-cdc ../tiflow
 
 msb-tidb: (_clone_without_submodules "tidb" "https://github.com/pingcap/tidb.git" "master")
     docker build --load -t localhost/tidb:local-build -f dockerfiles/cd/builders/tidb/Dockerfile ../tidb