Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RessourceManager constructor #30

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

christophfroehlich
Copy link
Contributor

I'm currently working on a CI job with downstream builds for ros2_control, and this package here fails.

The API of the RessourceManager has changed. To be able to compile this repository on jazzy+rolling, one has to pass some more arguments to it. I think it is time to branch-off humble and fix that for the newer distros.

@christophfroehlich
Copy link
Contributor Author

Well, that is also a possibility. but there is a simpler way: as we use ament_generate_version_header you simply can use

#include<hardware_interface/version.h>
#if HARDWARE_INTERFACE_VERSION_GTE(major, minor, patch) 
#endif

@christophfroehlich
Copy link
Contributor Author

@JafarAbdi shall I change it? And the CI job has now a wrong (humble) in the title.

@JafarAbdi
Copy link
Collaborator

Well, that is also a possibility. but there is a simpler way: as we use ament_generate_version_header you simply can use

#include<hardware_interface/version.h>
#if HARDWARE_INTERFACE_VERSION_GTE(major, minor, patch) 
#endif

I thought about using it, but it was introduced in 4.8.0 😿

@JafarAbdi
Copy link
Collaborator

@JafarAbdi shall I change it? And the CI job has now a wrong (humble) in the title.

It should be fixed now

@JafarAbdi JafarAbdi merged commit de05896 into PickNikRobotics:main Dec 12, 2024
4 checks passed
@christophfroehlich christophfroehlich deleted the fix/rm branch December 12, 2024 19:36
@christophfroehlich
Copy link
Contributor Author

I thought about using it, but it was introduced in 4.8.0 😿

Oh, we should backport that 🙈

@christophfroehlich
Copy link
Contributor Author

We have it now in the humble branch as well, maybe you'd consider updating this after the next release of ros2_control.

@JafarAbdi
Copy link
Collaborator

We have it now in the humble branch as well, maybe you'd consider updating this after the next release of ros2_control.

Thanks! I'll open a PR to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants