-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RessourceManager constructor #30
Conversation
Well, that is also a possibility. but there is a simpler way: as we use #include<hardware_interface/version.h>
#if HARDWARE_INTERFACE_VERSION_GTE(major, minor, patch)
#endif |
@JafarAbdi shall I change it? And the CI job has now a wrong |
I thought about using it, but it was introduced in |
It should be fixed now |
Oh, we should backport that 🙈 |
We have it now in the humble branch as well, maybe you'd consider updating this after the next release of ros2_control. |
Thanks! I'll open a PR to use it |
I'm currently working on a CI job with downstream builds for ros2_control, and this package here fails.
The API of the RessourceManager has changed. To be able to compile this repository on jazzy+rolling, one has to pass some more arguments to it. I think it is time to branch-off humble and fix that for the newer distros.