Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a main that uses all of the functional programming principles #26

Merged
merged 4 commits into from
Sep 16, 2023

Conversation

bgill92
Copy link
Collaborator

@bgill92 bgill92 commented Sep 15, 2023

Description

Wrote a main that uses functional programming principles and should have everything be testable in theory.

Testing

Launch the container and run colcon build. Ensure there are no errors.

Copy link
Collaborator

@griswaldbrooks griswaldbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to something like an experimental folder or something so it doesn't pollute the test folder with something that isn't a test?

functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
functional_programming_tests/test/main.cpp Outdated Show resolved Hide resolved
Comment on lines 243 to 246
rclcpp::Service<example_srvs::srv::SetMap>::SharedPtr set_map_service = node->create_service<example_srvs::srv::SetMap>("set_costmap", mo.set_costmap_wrapper_);

rclcpp::Service<example_srvs::srv::GetPath>::SharedPtr get_path_service = node->create_service<example_srvs::srv::GetPath>("generate_global_path", mo.generate_path_wrapper_);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disapprove

@griswaldbrooks griswaldbrooks merged commit 672b75d into ros2 Sep 16, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bgill92/add-functional-programming-main branch September 16, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants