-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setup CI using script #29
Conversation
- Run the same script that packages in ros-controls github org use - https://rtw.stoglrobotics.de/master/use-cases/ros_packages/configure_repository.html These will likely fail due to serial not being released for ROS2 - see #21 - wjwwood/serial#204 - wjwwood/serial#283 Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Note this PR is entirely auto-generated. I'm expecting it to fail, and will fix it up accordingly |
- we would prefer not to use the fork but we need to turn on CI - when wjwwood/serial#204 or wjwwood/serial#283 are closed we can switch - related to #21 Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
This is a formatting autofix Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
move author to after maintainer Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
serial is not yet release in ros2 so it is needed here for CI jobs Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Removing RHEL jobs for now will first focus on releasing for Ubuntu Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Removing these jobs for now until we have finished release Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the goal to have all test pass before we merge this PR?
Run pre-commit Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
and run pre-commit all files Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
This disables uncrustify we use clang format Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
- fixes copywrite linter complaint that these were missing Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 5
Lines ? 352
Branches ? 0
======================================
Hits ? 0
Misses ? 352
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yes... I didn't expect this PR to take so long. |
This reverts commit f3216fe.
ament_lint runs flake8 and flake8 and black are conflicting over " vs ' Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
With < clang-format will re-order When re-ordered cpplint complains Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
- disable ament_flake8, flake8 via pre-commit reads .flake8 config - ament_flake8 in ros-tooling didn't read .flake8 - flake8 and black will conflit over single vs double quotes Signed-off-by: Alex Moriarty <alex.moriarty@picknik.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we expect each ros release to need a different .repos
file? Would be nice if we could squash that down to a single file. This PR adds so many configuration files (but a lot of tests too!).
Basically the reason for each repo to have a uniq repos file is that they could require different branches... @destogl has a script which sets this all up, and is what is used for the ROS 2 Control related repos. I do agree that it pollutes the top directory with a bunch of stuff so maybe I re-organize and move them into a subdir |
These will likely fail due to serial not being released for ROS2
I don't want to squash merge this PR