-
Notifications
You must be signed in to change notification settings - Fork 6
Copy example Objectives from Mimic Sim to Mujoco, with latest comments #313
Conversation
The mock hardware objectives use the key To add them to the mujoco config without having to duplicate (and maintain two versions of) the objective you can add additional library paths by modifying these lines:
|
I don't know how to finish this PR, and do not currently have bandwidth, but I think these basic objectives to belong in our new example robot config package. Could someone finish this PR please? Note the reason I copied these in was because i added a lot of new descriptions and comments to those objectives, and didn't want them to get forever lost in the mock hw robot config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely not ready to merge, but it sounds like @bgill92 is assigned the issue for this: https://github.com/PickNikRobotics/moveit_studio/issues/8368.
I'll go ahead and note some changes that need to be made here:
- Move these objectives to a package (I think they are supposed to be in arm_on_rail_sim now since the mujoco config was renamed to that)
- Fix the waypoints
<Control ID="Sequence"> | ||
<SubTree ID="Move to Waypoint" waypoint_name="Grasp Left" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" planner_interface="moveit_default"/> | ||
<Action ID="MoveGripperAction" gripper_command_action_name="/robotiq_gripper_controller/gripper_cmd" position="0.7929"/> | ||
<SubTree ID="Move to Waypoint" waypoint_name="Look at Machine" joint_group_name="manipulator" controller_names="/joint_trajectory_controller /robotiq_gripper_controller" planner_interface="moveit_default"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Look at Machine" waypoint does not exist outside of the mock sim config
Replaced by #357 (review) |
Copy in these PRs to new Mujoco config
#308
#307
#306
#305