This repository has been archived by the owner on Dec 13, 2024. It is now read-only.
Add overlay Docker image option #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #11560: Create Template Dockerfile, .env, and docker-compose.yaml for Tutorials. |
eholum
reviewed
Mar 24, 2023
| # hadolint ignore=SC1091 | ||
| RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \ | ||
| --mount=type=cache,target=/var/lib/apt,sharing=locked \ | ||
| . "${OVERLAY_WS}/install/setup.sh" && \ |
There was a problem hiding this comment.
Someday we should get on renaming this.
There was a problem hiding this comment.
yeah... overlay is such a loaded word. Giovanni was right all along and we shouldn't have used other ROS repos as precedent lol
|
Thanks for the comments, @eholum -- I implemented them all! |
MikeWrock
reviewed
Mar 24, 2023
MikeWrock
added a commit
that referenced
this pull request
Mar 28, 2023
* Update config packages and example Behaviors * Add overlay Docker image option (#1) Co-authored-by: Michael Wrock <Michael Wrock> Co-authored-by: Sebastian Castro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses [sc-11560] by adding the option for users to build their own release / dev images on top of our binaries containers for Studio.
In these cases, there would be no notion of a "user workspace" as it's all contained within the image (treated the same way the overlay workspace would in core Studio).
I say "partially addresses" because the tutorial portion of this needs to happen in our actual docs.