Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly state and cite cutting edge optimization approaches to determine phase angles #941

Merged
merged 2 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demonstrations/tutorial_apply_qsvt.metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
],
"dateOfPublication": "2023-08-22T00:00:00+00:00",
"dateOfLastModification": "2023-09-05T00:00:00+00:00",
"dateOfLastModification": "2023-09-28T00:00:00+00:00",
"categories": [
"Quantum Computing",
"Algorithms",
Expand Down
8 changes: 4 additions & 4 deletions demonstrations/tutorial_apply_qsvt.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def my_circuit(phase_angles):
#
# Phase Angles from PyQSP
# ^^^^^^^^^^^^^^^^^^^^^^^
# There are many methods for computing the phase angles (see [#phaseeval]_,
# There are many numerical methods for computing the phase angles (see
# [#machineprecision]_, [#productdecomp]_). They can be readily used with
# PennyLane as long as the convention used to define the rotations
# matches the one used when applying QSVT. This is as simple as specifying the
Expand Down Expand Up @@ -271,9 +271,9 @@ def loss_func(phi):
plt.show()

###############################################################################
# Awesome, we successfully optimized the phase angles! While we used a standard loss function
# and optimizer, users have the freedom to explore any optimizer, loss function, and sampling
# scheme when training the phase angles for QSVT.
# Awesome, we successfully optimized the phase angles! While we used a simple loss function
# and optimizer, more sophisticated optimization schemes have been presented in literature to
# robustly train the phase angles for QSVT (see [#phaseeval]_).
Jaybsoni marked this conversation as resolved.
Show resolved Hide resolved
#
# Let :math:`\hat{U}_{qsvt}(\vec{\phi}, x)` represent the unitary matrix of the QSVT algorithm.
# Both of the methods above produce phase angles :math:`\vec{\phi}` such that:
Expand Down