Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly state and cite cutting edge optimization approaches to determine phase angles #941

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

Jaybsoni
Copy link
Contributor

Summary: Upon review, we realized that one of the cited approaches to compute the phase angles belongs in the "optimization" section. It's an important result and the cutting edge in methods for computing phase angles. For this reason we update the demo to add more emphasis to it.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 941
  • Deployment SHA: 3dc779cb2e53c203edfc697300536c25b3b7fba4
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Jaybsoni Jaybsoni requested a review from soranjh October 4, 2023 19:38
@KetpuntoG
Copy link
Contributor

@Jaybsoni ready to merge?

@Jaybsoni Jaybsoni enabled auto-merge (squash) October 5, 2023 05:23
@Jaybsoni Jaybsoni merged commit be8aa37 into master Oct 5, 2023
10 checks passed
@Jaybsoni Jaybsoni deleted the update_qsvt_demo branch October 5, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants