Pin dependencies #26
Merged
Pin dependencies #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #25 for me. +1 for merging this into 1.0.5 |
|
Thank you for your job 👍 |
|
Just my recommendation - using travis-ci together with greenkeeper.io will automagically test and PR when new versions arrive on NPM - keeping everything green and up-to-date. Maybe i have time to spent on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps against things suddenly exploding in your face, such as our deploys today because xmldom slipped a not-so-backwards-compatible update in a patch version. Who can blame them, it's impossible to know all the different ways people are using your project and what effects a minor change might have, and how that might break things in subtle or not so subtle ways for them.
Long story short, let's pin dependencies so any change is explicit & tested, and our builds and deploys are reproducible.
See #25